bug 335792 - correcting '@since' annotations and minor clean-upI20140319-2200I20140318-2200I20140317-2200I20140316-2200I20140315-2200I20140314-2200I20140314-0615I20140313-2200I20140312-2200I20140311-2200I20140310-2200I20140309-2200I20140308-2200I20140307-2200I20140307-0615I20140306-2200I20140305-2200I20140304-2200I20140303-2200I20140302-2200I20140301-2200I20140228-2200I20140228-0615I20140227-2200I20140227-1440I20140226-2200I20140225-2200I20140224-2200I20140223-2200I20140222-2200I20140221-2200I20140220-2200I20140220-1440I20140219-2200I20140218-2200I20140217-2200I20140216-2200I20140215-2200I20140214-2200I20140213-2200I20140213-1440I20140212-2200I20140212-1610I20140211-2200I20140210-2200I20140209-2200I20140208-2200I20140207-2200I20140206-2200I20140205-2200I20140205-1610I20140204-2200I20140203-2200I20140202-2200I20140201-2200I20140131-2200I20140130-2200I20140129-2200I20140129-1610I20140128-2200I20140127-2200I20140126-2200I20140125-2200

12 files changed, 72 insertions, 3 deletions

diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ChangeEvent.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ChangeEvent.java
index a225c492..4a67471a 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ChangeEvent.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ChangeEvent.java
@@ -37,6 +37,9 @@ public class ChangeEvent extends
 		super(source);
 	}
 
+	/**
+	 * @since 1.5
+	 */
 	protected void dispatch(IChangeListener listener) {
 		listener.handleChange(this);
 	}
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ChangeSupport.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ChangeSupport.java
index a1204351..1fd86460 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ChangeSupport.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ChangeSupport.java
@@ -28,10 +28,19 @@ package org.eclipse.core.databinding.observable;
  */
 public abstract class ChangeSupport {
 
+	/**
+	 * @since 1.5
+	 */
 	protected ListenerList<IChangeListener> genericListenerList = null;
 
+	/**
+	 * @since 1.5
+	 */
 	protected ListenerList<IStaleListener> staleListenerList = null;
 
+	/**
+	 * @since 1.5
+	 */
 	protected ListenerList<IDisposeListener> disposeListenerList = null;
 
 	/**
@@ -44,7 +53,7 @@ public abstract class ChangeSupport {
 	}
 
 	/**
-	 * 
+	 * @since 1.5
 	 */
 	public ChangeSupport() {
 	}
@@ -190,7 +199,28 @@ public abstract class ChangeSupport {
 	}
 
 	/**
+	 * @param event
+	 * @since 1.5
+	 */
+	protected void fireChange(ChangeEvent event) {
+		if (genericListenerList != null) {
+			genericListenerList.fireEvent(event);
+		}
+	}
+
+	/**
+	 * @param event
+	 * @since 1.5
+	 */
+	protected void fireStale(StaleEvent event) {
+		if (staleListenerList != null) {
+			staleListenerList.fireEvent(event);
+		}
+	}
+
+	/**
 	 * @param disposeEvent
+	 * @since 1.5
 	 */
 	public void fireDispose(DisposeEvent disposeEvent) {
 		if (disposeListenerList != null) {
@@ -201,6 +231,7 @@ public abstract class ChangeSupport {
 	/**
 	 * @param listenerList
 	 * @param listener
+	 * @since 1.5
 	 */
 	protected <EV extends ObservableEvent<EV, L>, L extends IObservablesListener<L>> void addListener(
 			ListenerList<L> listenerList, L listener) {
@@ -214,6 +245,7 @@ public abstract class ChangeSupport {
 	/**
 	 * @param listenerList
 	 * @param listener
+	 * @since 1.5
 	 */
 	protected <EV extends ObservableEvent<EV, L>, L extends IObservablesListener<L>> void removeListener(
 			ListenerList<L> listenerList, L listener) {
@@ -252,6 +284,15 @@ public abstract class ChangeSupport {
 	}
 
 	/**
+	 * 
+	 */
+	protected void dispose() {
+		genericListenerList = null;
+		staleListenerList = null;
+		disposeListenerList = null;
+	}
+
+	/**
 	 * Releases all listener references
 	 */
 	// protected void dispose() {
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/DisposeEvent.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/DisposeEvent.java
index 1ae8e821..6775323e 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/DisposeEvent.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/DisposeEvent.java
@@ -35,6 +35,9 @@ public class DisposeEvent extends
 		super(source);
 	}
 
+	/**
+	 * @since 1.5
+	 */
 	protected void dispatch(IDisposeListener listener) {
 		listener.handleDispose(this);
 	}
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/StaleEvent.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/StaleEvent.java
index a0b2885d..82c95c6c 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/StaleEvent.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/StaleEvent.java
@@ -43,6 +43,9 @@ public class StaleEvent extends ObservableEvent<StaleEvent, IStaleListener> {
 
 	static final Object TYPE = new Object();
 
+	/**
+	 * @since 1.5
+	 */
 	protected void dispatch(IStaleListener listener) {
 		listener.handleStale(this);
 	}
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListChangeEvent.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListChangeEvent.java
index ecdb8648..8d87be44 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListChangeEvent.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListChangeEvent.java
@@ -69,6 +69,9 @@ public class ListChangeEvent<E> extends
 		return typedSource;
 	}
 
+	/**
+	 * @since 1.5
+	 */
 	protected void dispatch(IListChangeListener<E> listener) {
 		listener.handleListChange(this);
 	}
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListListenerManager.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListListenerManager.java
index e2730a01..277a3690 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListListenerManager.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListListenerManager.java
@@ -12,8 +12,11 @@
 package org.eclipse.core.databinding.observable.list;
 
 /**
+ * This class was essentially created to aid with generics and type-safety. It
+ * allows <?> to be bound to <E2>.
  * 
  * @param <E2>
+ * @since 1.5
  */
 public abstract class ListListenerManager<E2> {
 	/**
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/MapChangeEvent.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/MapChangeEvent.java
index eba1ddad..b66a9443 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/MapChangeEvent.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/MapChangeEvent.java
@@ -69,6 +69,9 @@ public class MapChangeEvent<K, V> extends
 		return typedSource;
 	}
 
+	/**
+	 * @since 1.5
+	 */
 	protected void dispatch(IMapChangeListener<K, V> listener) {
 		listener.handleMapChange(this);
 	}
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/SetChangeEvent.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/SetChangeEvent.java
index e0e6883f..73cdd7b1 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/SetChangeEvent.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/SetChangeEvent.java
@@ -66,6 +66,9 @@ public class SetChangeEvent<E> extends
 		return typedSource;
 	}
 
+	/**
+	 * @since 1.5
+	 */
 	protected void dispatch(ISetChangeListener<E> listener) {
 		listener.handleSetChange(this);
 	}
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/SetListenerManager.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/SetListenerManager.java
index f4309ff3..61d9b2f3 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/SetListenerManager.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/SetListenerManager.java
@@ -14,6 +14,7 @@ package org.eclipse.core.databinding.observable.set;
 /**
  * 
  * @param <E2>
+ * @since 1.5
  */
 public abstract class SetListenerManager<E2> {
 	/**
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/AbstractObservableValue.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/AbstractObservableValue.java
index f75c8448..4458b64f 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/AbstractObservableValue.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/AbstractObservableValue.java
@@ -55,7 +55,7 @@ abstract public class AbstractObservableValue<T> extends AbstractObservable
 
 	public synchronized void addValueChangeListener(
 			IValueChangeListener<T> listener) {
-		addListener(getValueChangesetListenerList(), listener);
+		addListener(getValueChangeListenerList(), listener);
 	}
 
 	public synchronized void removeValueChangeListener(
@@ -65,7 +65,7 @@ abstract public class AbstractObservableValue<T> extends AbstractObservable
 		}
 	}
 
-	private ListenerList<IValueChangeListener<T>> getValueChangesetListenerList() {
+	private ListenerList<IValueChangeListener<T>> getValueChangeListenerList() {
 		if (valueListenerList == null) {
 			valueListenerList = new ListenerList<IValueChangeListener<T>>();
 		}
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangeEvent.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangeEvent.java
index d175bbc4..059b0dd1 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangeEvent.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangeEvent.java
@@ -67,6 +67,9 @@ public class ValueChangeEvent<T> extends
 		return typedSource;
 	}
 
+	/**
+	 * @since 1.5
+	 */
 	protected void dispatch(IValueChangeListener<T> listener) {
 		listener.handleValueChange(this);
 	}
diff --git a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangingEvent.java b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangingEvent.java
index 370505e5..9cc99b90 100644
--- a/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangingEvent.java
+++ b/bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ValueChangingEvent.java
@@ -65,6 +65,9 @@ public class ValueChangingEvent<T> extends
 		return (IObservableValue<?>) source;
 	}
 
+	/**
+	 * @since 1.5
+	 */
 	protected void dispatch(IValueChangingListener<T> listener) {
 		listener.handleValueChanging(this);
 	}