diff options
| author | Brian Vosburgh | 2012-09-17 16:21:24 +0000 |
|---|---|---|
| committer | Brian Vosburgh | 2012-09-17 16:21:24 +0000 |
| commit | 84f972b4ac4689e289b47f1244446f5e60386fba (patch) | |
| tree | 755dc0f59c8699639f96a9058e868090f25a71f4 | |
| parent | a627549fa7546e68d2b259256deac99675846200 (diff) | |
| download | webtools.dali-84f972b4ac4689e289b47f1244446f5e60386fba.tar.gz webtools.dali-84f972b4ac4689e289b47f1244446f5e60386fba.tar.xz webtools.dali-84f972b4ac4689e289b47f1244446f5e60386fba.zip | |
remove unnecessary clone iterable from
AbstractJpaProject.getValidationMessages(...)
| -rw-r--r-- | jpa/plugins/org.eclipse.jpt.jpa.core/src/org/eclipse/jpt/jpa/core/internal/AbstractJpaProject.java | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/jpa/plugins/org.eclipse.jpt.jpa.core/src/org/eclipse/jpt/jpa/core/internal/AbstractJpaProject.java b/jpa/plugins/org.eclipse.jpt.jpa.core/src/org/eclipse/jpt/jpa/core/internal/AbstractJpaProject.java index d75ad1830b..e252dcf483 100644 --- a/jpa/plugins/org.eclipse.jpt.jpa.core/src/org/eclipse/jpt/jpa/core/internal/AbstractJpaProject.java +++ b/jpa/plugins/org.eclipse.jpt.jpa.core/src/org/eclipse/jpt/jpa/core/internal/AbstractJpaProject.java @@ -71,7 +71,6 @@ import org.eclipse.jpt.common.utility.internal.iterables.CompositeIterable; import org.eclipse.jpt.common.utility.internal.iterables.EmptyIterable; import org.eclipse.jpt.common.utility.internal.iterables.FilteringIterable; import org.eclipse.jpt.common.utility.internal.iterables.LiveCloneIterable; -import org.eclipse.jpt.common.utility.internal.iterables.SnapshotCloneIterable; import org.eclipse.jpt.common.utility.internal.iterables.TransformationIterable; import org.eclipse.jpt.jpa.core.JpaDataSource; import org.eclipse.jpt.jpa.core.JpaFile; @@ -1489,11 +1488,13 @@ public abstract class AbstractJpaProject // ********** validation ********** public Iterable<IMessage> getValidationMessages(IReporter reporter) { - List<IMessage> messages = new ArrayList<IMessage>(); + ArrayList<IMessage> messages = new ArrayList<IMessage>(); this.validate(messages, reporter); - return new SnapshotCloneIterable<IMessage>(messages); + return messages; } + // TODO about the only use for the reporter is to check for cancellation; + // we should check for cancellation... protected void validate(List<IMessage> messages, IReporter reporter) { if (reporter.isCancelled()) { throw new ValidationCancelledException(); |