Skip to main content
path: root/launch
AgeCommit message (Collapse)AuthorFilesLines
2019-08-12Convert new Runnable to lambda.Alexander Kurtakov3-52/+30
Take 2. Change-Id: I060b0e41d8c6058db0c2ba88af8454b5517105b8 Signed-off-by: Alexander Kurtakov <>
2019-08-12Convert new Runnable to lambda. Alexander Kurtakov4-65/+39
Change-Id: I8b827013a29802a3f3ae6400ddce8d8753eb6399 Signed-off-by: Alexander Kurtakov <>
2019-08-10Remove redundant superinterfaces. Alexander Kurtakov4-9/+4
Change-Id: I0de3509b02a8ef6853f0053c9ee6edd304a05a86 Signed-off-by: Alexander Kurtakov <>
2019-08-09Remove unneeded suppress warnings.Alexander Kurtakov3-4/+2
Change-Id: I6b552fd94ced0cd8c0d489386d4b594ae7df8fdf Signed-off-by: Alexander Kurtakov <>
2019-07-25Fix up some problems found against the latest API baseline.Doug Schaefer3-2/+8
Change-Id: I5679b36166385b617a96ef8180bbd27ae002e900
2019-07-09Bug 542488: Remove duplicated codeJonah Graham6-200/+380
When DSF was first created it was a separate project that borrowed heavily from CDT, as such (AFAICT) some code was copied from o.e.cdt.launch to DSF. This commit de-duplicates some of that code as the DAP implementation wants to reuse the code too and another copy is not wanted. Change-Id: Ie54187dabc9c32224575c0bf51bcabfab00ca340
2019-06-11[releng] Bump version to 9.9.0Jonah Graham3-3/+3
Change-Id: I6641e51a8bfdb44fa5c646d97debf2bf814c107a
2019-05-22Bug 547442 - Launchbar shouldn't set newly added Container target activeJeff Johnston1-2/+4
- change ContainerTargetTypeProvider.changeEvent() to use the new ILaunchTargetManager2 interface to use addLaunchTargetNoNotify to add image targets from a new or enabled Docker connection so as to prevent scanner info jobs Change-Id: I2aef96c86c926790702a59853f0baf103c7115fc
2019-05-15Bug 547145 - Core build use of ProjectDescription should be synchronizedJeff Johnston1-3/+7
- also change ContainerLaunchConfigurationDelegate Change-Id: I5574d67ae030e728605c12f7bc05bcbb8e23e83d
2019-05-13Bug 547104 - Adding new Docker Connection causes two build dirsJeff Johnston1-2/+40
- copy ChangeEvent logic from ContainerGCCToolChainProvider to ContainerTargetTypeProvider when a new connection is added Change-Id: Idbdaba7d10e4590722ff442447d195a3a2485907
2019-05-06Bug 547026 - fix ConcurrentModificationExceptionJeff Johnston1-1/+3
- in ContainerGCCToolChainProvider change collection of toolchains to be an array before accessing to prevent ConcurrentModificationException Change-Id: Ia39ddee181ba814997a34d5b1d68170fe1cda5ce
2019-04-23Bug 546518 - Container gcc toolchain should just depend on pathJeff Johnston1-7/+3
- change ContainerGCCToolChain.getCommandPath() to just return the command - change default command to be gcc instead of /usr/bin/gcc Change-Id: I62869d974e7fc9707ee02dc6f5e2ab4500ddd0bc
2019-03-20Bug 545192 - Convert directory path in docker for windowsHannes Vogt2-2/+2
Change-Id: I69c09d391e333495b57f09d7b7f5818a5428424f Signed-off-by: Hannes Vogt <>
2019-03-01[releng] Bump version to 9.8.0Jonah Graham3-3/+3
Change-Id: I3861d4c5d0eecaf9dd370f269a655e666b60561a
2019-02-07Bug 509263 - Fix warnings for missing enablement expression on start-upSimeon Andreev2-1/+3
This change adds empty enablement expressions where they are missing, in order to prevent start-up warnings such as: Enablement expression is missing for config provider for org.eclipse.cdt.debug.core.coreBuildDescriptorType Change-Id: Id7f2b6149230ddde24764772c5b67ff5eef28b65 Signed-off-by: Simeon Andreev <>
2018-12-10[releng] Bump version to 9.7.0Jonah Graham3-3/+3
Change-Id: Icaa0b6acf73e3a19e0d102fa8ae784e631d8743a
2018-11-29Bug 541709 Fix up exceptions when we can't find toolchains.Doug Schaefer1-3/+2
We weren't checking the case where the size of the toolchains array was zero. Return a null config in that case and fix up the CommonBuildTab to deal with that. Change-Id: Ibd8f659988f1463570bdb2654d6ea2b4a45866c2
2018-11-24Bug 540373: Update the compiler warnings/ignoresJonah Graham2-2/+2
The previous alignment of all the warnings/ignores led to too many warnings that weren't there before. This commit relaxes them a bit. The core/org.eclipse.cdt.core/.settings/org.eclipse.jdt.core.prefs is still the "master" copy, with releng/scripts/ containing the exceptions that apply to test plug-ins. Change-Id: Ibd4e31ade0b42b31e7cbe5a94f06c6fc15183a56
2018-11-23Bug 540373: Cleanup: Remove trailing whitespace in properties filesJonah Graham2-6/+6
Command used: # Remove space at eol in comments find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/^(#.*)[ \t]+$/\1/' {} + # Remove space at eol in blank lines find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/^[ \t]+$//' {} + # Replace escaped spaces at eol with unicode find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\\ $/\1\\u0020/' {} + # Replace unescaped spaces at eol with unicode find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\]) $/\1\\u0020/' {} + # Replace escaped tabs at eol with unicode find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\\\t$/\1\\u0009/' {} + # Replace unescaped tabs at eol with unicode find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\t$/\1\\u0009/' {} + # Stage all changes git add -A . # trim any remaining whitespace and then identify and fixup # manually # Only dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/ui/viewmodel/ # needed this due to missing newline at end of the file find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/[ \t]+$//' {} + Change-Id: I858f16891fe001f4f7e62d5a4f904146e891cd39
2018-11-22Bug 540373: Cleanup: Remove trailing whitespace in Java filesJonah Graham1-1/+1
Some Java files were missed, or other cleanups introduced trailing whitespace. So clean it up with this commit. Command used: find . ! -path "./.git/*" -type f -name *.java -exec sed -i -E 's/[ \t]+$//' {} + Change-Id: I18f5e3a3eb5352443c9e753d427bb8d06107b8a4
2018-11-22Bug 540373: Remove '(non-Javadoc)' commentsJonah Graham12-210/+0
These were inserted in the past automatically by Eclipse but newer tooling makes them redundant. These were removed by doing a global find/replace on *.java files using the following regular expression: \t/\*\n\t \* \(non-Javadoc\)[^/]*/\n Change-Id: I59d3248020f10934fde1dda5b5a31e20bb188e19
2018-11-22Bug 540373: Cleanup: Remove redundant semicolonsJonah Graham2-2/+2
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Remove redundant semicolons and completing the wizard Change-Id: I3d3175cfdfadec4f815c551d486e42c9f57b80ce
2018-11-22Bug 540373: Cleanup: Remove redundant type argumentsJonah Graham10-19/+19
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Remove redundant type arguments and completing the wizard Change-Id: Iaecc7010f097b4b1fabd29ccaa34ccb23a716fbf
2018-11-22Bug 540373: Cleanup: Remove unnecessary castsJonah Graham3-5/+5
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Remove unnecessary casts and completing the wizard Change-Id: I287d4066b12fc19d7f73a016e11c9405abb4ceb9
2018-11-22Bug 540373: Cleanup: Add missing annotationsJonah Graham5-0/+9
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Add missing Annotations - and selecting all three types: - @Override - @Override on interface methods - @Deprecated and completing the wizard Change-Id: I5d367dacb04327107f25e147edc08efc4eb1c2fe
2018-11-22Bug 540373: Cleanup: Format & Remove trailing whitespaceJonah Graham66-2884/+2059
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Format source code - Remove trailing white spaces on all lines and completing the wizard Change-Id: I63685372c6bcc67719bcf145123bcb72e5b00394
2018-11-22Bug 540373: Standard .settings auto appliedJonah Graham10-33/+1244
The releng/scripts/ was run to copy standard settings to all other projects. Change-Id: I4436c947d7f0142f56b709e661379c3eb54f666b
2018-11-22Bug 540371: Update to EPLv2 using releng/scripts/change_to_eplv2.shJonah Graham82-279/+539
Change-Id: Ifbb1d5af2a00bd5634dea200320e8c4303ffca6c
2018-11-22Bug 540371: normalize files before applying EPLv2Jonah Graham1-1/+6
Change-Id: I8bfd427bba1df18579d6d5e58ad1e5d704485050
2018-11-20Bug 540373: Normalize newlines with .gitattributesJonah Graham4-801/+801
There is also a new script to verify completeness of .gitattributes: releng/scripts/ Change-Id: I2ce270852ab54b66b6c474a6ec94203fe5bba78b
2018-11-08Bug 540423 - C/C++ Container Launcher missing Port BindingJeff Johnston8-6/+917
- add new ContainerPortDialog class to allow user to specify ports in the launch configuration Container tab - add new ContainerTabModel and ExposedPortModel classes to support new functionality - add new Ports group to ContainerTab and have a table where a user can add, edit, remove, and select ports for publishing to the host - add new attribute ATTR_EXPOSED_PORTS to ILaunchConstants for saving and restoring user selected ports in C launch configuration - add needed internal messages to support new port settings functionality - bump up org.eclipse.cdt.docker.launcher version Change-Id: I93b7503bdc141e3077418800352507ef38e65ab1
2018-10-30Bug 540610 - Add Automatic-Module-Name headerKarsten Thoms2-0/+2
Change-Id: Ia990b24469751050dd9ec8f9b5550804816308b3 Signed-off-by: Karsten Thoms <>
2018-10-23Bug 540410 - ContainerTargetTypeProvider causes ClassNotFoundExceptionJeff Johnston1-1/+1
- bump up minimum org.eclipse.cdt.core needed for org.eclipse.cdt.docker.launcher plug-in so that ICBuildConfigurationManager2 interface is available Change-Id: I5e77e7b43bdea1f0b59c79fcdfced7c162b64e9a
2018-10-23Bug 540367 - Increment version numbersWilliam Riley2-2/+2
Change-Id: I4a355170a7075f0a98ba3c1a5131c235c89b07d2
2018-10-12Bug 540085 - Deadlock in ToolChainManager initJeff Johnston2-13/+38
- modify ContainerGCCToolChainProvider.init so that the CBuildConfigurationManager.recheckConfigs() call is done within a separate job so the init() call will return without causing deadlock - do the same for ContainerTargetTypeProvider - modify CBuildConfigurationManager initProviders() method to be synchronized Change-Id: I4ca9371fb340887233872b6d315621a24450fb2b
2018-09-12Bug 538958 - Meson project built in Container not indexing properlyJeff Johnston1-2/+4
- add synchronized keyword to the various scanner info collecting methods in ContainerGCCToolChain Change-Id: I476e0c191379621d5ca8ef266c8590a0954ab4a5 (cherry picked from commit 55569e158ce4a1026f3d2405945154d349dc724c)
2018-07-12Bug 536884 - Removing header cache should cause ScannerInfo refreshJeff Johnston2-2/+16
- add a new IToolChain property "cdt.needScannerRefresh" that is set if scanner info needs to be refreshed - for a Container build, turn the property on in ContainerGCCToolChain startBuildProcess() if the Container headers for the toolchain's have been deleted - in CBuildConfiguration processLine(), look for the toolchain property when looking to see if scannerinfo should be calculated - in CBuildConfiguration, turn the toolchain property off in shutdown() Change-Id: I67a3537d1e2967dc15b66a1c37abda1ae8f78bff
2018-07-11Bug 533363 - Indexer spending a lot of time in CommandLauncherManagerJeff Johnston1-5/+36
- it seems that fetching the active configuration for a project using an ICConfigurationDescription is time-consuming - the active configuration is sought in ContainerCommandLauncherFactory to get the optional build properties and thus we can figure out if the active configuration has enabled container build or not - see if we are given a CConfigurationDescriptionCache and it contains a BuildConfigurationData element which allows us to get an IConfiguration without creating a new one, serializing it etc.. which is adding to the time taken Change-Id: I8973f1707a602a73fc5ac751f12a1e8dbd549aab
2018-07-04Bug 536363 - Meson project include paths wrong when using ccacheJeff Johnston1-2/+10
- fix GCCToolChain and ContainerGCCToolChain to not blindly take the first token in the command string when processing scannerinfo; if it is "ccache", take the second token instead Change-Id: I4b2b7dfaccae6f3ec968bbe4217c57994ad71963
2018-07-03Bug 536317 - Deadlock at start with launchbar and docker tooling enabledJeff Johnston2-135/+206
- fix ContainerTargetTypeProvider changeEvent() to start a Job and return immediately so it will not cause a DockerConnection to be held in multi-threading - move the DockerConnectionManager addConnectionListener call to end of init() method so the fetching of images won't cause a notification event to occur - at end of init(), call CBuildConfigurationManager.recheckConfigs() to make sure any disabled configuration due to a missing IDockerConnection is now put in the configs master list and removed from the noconfigs list - make similar changes to ContainerGCCToolChainProvider Change-Id: Idc120d613b99ec365522f5e7bf5da82d1b362425
2018-06-05[releng] Bump version to 9.6.0Jonah Graham3-3/+3
Change-Id: I1618eaeab14b421155af733a73e36f6e37ea0b85
2018-06-02Bug 535473 - Run/Debug buttons for Container target don't run/debugJeff Johnston2-5/+69
- Launch bar is usually expecting a LaunchConfigurationTargeted Delegate which calculates the binary but Container build uses the ContainerLaunchConfigurationDelegate which expects the program name, working dir, connection, and image id set up as ILaunchConfiguration attributes - modify ContainerLaunchConfigurationDelegate to add finalLaunchCheck method which can verify if the launch config attributes are set up and if not, set them from the build config (since this is post-build) - fix getImageName() in CoreBuildContainerLaunchConfigProvider to use toolchain attributes Change-Id: Iad6cc26928c33e964650b99844e065df8653858f
2018-05-23Bug 535014 - cannot debug in a containerJeff Johnston1-14/+13
- add check for network ports coming back empty for a Container launch and if so, fall-back to use the ip address of the Container for the remote host Change-Id: I83d68a10e2dc92f7d0f27bb9dec304388594b4a3
2018-05-07Bug 533842 - Fix Launchbar for enabled/disabled Docker ConnectionsJeff Johnston2-9/+13
- fix problem with launch targets not being set correctly - for ContainerTargetTypeProvider, make init() and changeEvent() synchronized - move the test for ESTABLISHED connection after getImages() in ContainerTargetTypeProvider.init() method so that we don't see the connection as being UNKNOWN - move addConnectionManagerListener() call in init() to be just after we fetch the list of current connections - in ContainerGCCToolChainProvider, make init() and changeEvent() synchronized and move addConnectionManagerListener call to just after connections list are acquired Change-Id: I24880a77755d634e8bce85db4f3354cf5ad7671d
2018-04-20Bug 533842 - Fix Launchbar for enabled/disabled Docker ConnectionsJeff Johnston2-2/+195
- fix CMakeBuildConfigurationProvider to not verify if a toolchain file exists which doesn't occur for Container Build configurations - add new ICBuildConfigurationManager2 interface that adds new recheckConfigs() method, make CBuildConfigurationManager implement this new interface - add new recheckConfigs() method to CBuildConfigurationManager so that if a Docker Connection is enabled, the list of invalid configs can be rechecked and those that are now valid can be removed from the noconfigs list - have ContainerGCCToolChainProvider implement IDockerConnectionManagerListener and register itself as a listener during init - add new changeEvent() method as part of a listener that will add toolchains for connections that are added/enabled and similarly will delete toolchains for connections that are removed/disabled - do the same with ContainerTargetTypeProvider (making it be an IDockerConnectionManagerListener and adding/deleting targets based on whether a Docker Connection is added/enabled or deleted/disabled - as well during the init process of ContainerTargetTypeProvider remove any targets for Connections that aren't established Change-Id: Id5e9415eaa770ef7f6ba1ddd11312ed003585391
2018-04-17Bug 533499 - Check all problem markers for errorsSamuel Hultgren1-2/+3
Check all problem markers until one with severity Error or higher has been found. Change-Id: I7b44727eb1f323da75a7aa58bcea2ef307801adf Signed-off-by: Samuel Hultgren <>
2018-04-16Bug 533222 - Add Container Build support to Std Make Core BuildJeff Johnston2-1/+82
- add new getConsoleHeader() method to ICBuildCommandLauncher interface and ContainerCommandLauncher class - modify MakefileBuildConfigurationProvider to create build configurations based on an Image name when building for Container and as well support the linux-container os that is used for Container targets - add new IConsoleParser2 interface that extends IConsoleParser and adds new processLine method that takes a List of Job as a parameter - make CBuildConfiguration implement IConsoleParser2 and add new processLine method - modify watchProcess to recognize an IConsoleParser2 and pass a Job List then wait for all jobs to finish before calling shutdown() and possibly reindex - add new IToolChain2 interface with startBuildProcess() method - add new startBuildProcess() method to CBuildConfiguration to look for new IToolChain2 and use its startBuildProcess() method to perform the build - make ContainerGCCToolChain implement IToolChain2 and add new startBuildProcess() method to build in Container - change StandardBuildConfiguration to use startBuildProcess() to do build and clean Change-Id: Icae9a55ef6abfa1b7f611544ad591b6062c72585
2018-03-19Bug 532420 - Make Container Core Build indexing more efficientJeff Johnston2-4/+16
- add new ICBuildConfiguration2 to keep API checks happy - remove refreshScannerInfo method from ICBuildConfiguration and put it in ICBuildConfiguration2 - make CBuildConfiguration implement ICBuildConfiguration2 - update ContainerPropertyVolumesModel to use new Docker plug-ins using docker-client 8.9.2. - fix MesonBuildConfiguration to use a job for each compile line being processed, then wait until all jobs are done before causing an reindex to occur (this will maximize parallelism when building in Containers) - fix ContainerCommandLauncherFactory to save the project so we can exclude project directories when copying header files using the new Docker Tooling interfaces - fix CoreBuildLaunchBarTracker to use ICBuildConfiguration2 interface to make the call to refreshScannerInfo Change-Id: I2138f5111614e7821e46c22731397a01035eac0a
2018-03-09[releng] Add version constraints on linuxtools due to API changeJonah Graham1-2/+2
This really should have been part of I68d4f93de3a0e6141c7a37a34f9e8fdb2313fbd8 Change-Id: I1b7671fbd12dd973139e72f053e3b3d5117f3b44
2018-03-09[releng] Update CDT in preparation for Photon M6Jonah Graham1-1/+2
The most significant change for CDT is the upgrade of com.spotify.docker.client which has knock on effects due to the API changes. Includes: - Updating target platform - removing Neon and Oxygen as potential target platforms in OOMPH setup - Updating CDT standalone debugger - Changes in API for docker changes Change-Id: I68d4f93de3a0e6141c7a37a34f9e8fdb2313fbd8

Back to the top