Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/dsf-gdb
AgeCommit message (Collapse)AuthorFilesLines
2016-06-27Bug 495623: Use new flags in =record-change from upcoming GDB releaseMarc Khouzam1-15/+86
With the next GDB (probably named 7.12), we are provided with the type of record that was started. =record-started,thread-group="i1",method="btrace",format="bts" =record-started,thread-group="i1",method="btrace",format="pt" =record-started,thread-group="i1",method="full" We make use of this information in GDBRunControl_7_10 to avoid sending an 'info record' command. Note that because MI adds fields in a backwards-compatible way, it was much simpler to modify GDBRunControl_7_10 instead of creating a new GDBRunControl_7_12 (whose name may even be wrong if GDB's next version is not actually 7.12). Change-Id: I869b3c0ff648d5e38081e06a7063613bbb9266dc
2016-06-27Bug 496818 - Cannot find executable if working directory is not defaultMarc Khouzam1-25/+52
Originally, to determine the program path, GDBBackend's constructor would call: ICProject cproject = LaunchUtils.getCProject(lc); fProgramPath = LaunchUtils.verifyProgramPath(lc, cproject); When we made the change in 192bfff688f78729376a5063ae91e387fd04534b we didn't keep that logic and lost some functionality. This commit re-instates the original logic. Change-Id: Ifbee2273517c41ad6ebdc9980261ed36d651f130
2016-06-22Move the rest of the CDT plugins to java 8Marc Khouzam9-15/+15
This change was generated using the script: releng/scripts/ChangeJavaVersion.sh Change-Id: I2ad96dc682a5acb8529c3edec40de279c331b5a4
2016-06-20Fix wrong javadocMarc Khouzam1-2/+2
Change-Id: Ie4388f47fad9a1ed760fbe4576e01d408c0ca6ba
2016-06-14Cherry picking changes from the CDT 9 branch for Qt and Arduino.Doug Schaefer2-9/+8
Change-Id: I85eca2b8bb0447d4dd703030c41d90c1f9bcdf89
2016-06-01Adding GDB 7.11.1 to the download-build-gdb.sh scriptAlvaro Sanchez-Leon1-1/+1
Change-Id: Ic22f35bb5bac2c3ac1fb394073b168d48259f4f6
2016-05-26Allow to more easily extend GDBControl service.Marc Khouzam4-57/+103
Change-Id: Iec5ef773222390237d4665fb9bd3daa5b3cae947
2016-05-25Bug 494504 - Reverse API changes to GdbDebugServicesFactoryJonah Graham1-3/+31
This change reverses the breaking API changes made to GdbDebugServicesFactory as part of Bug 488909 while retaining the code cleanup done in that bug. Change-Id: If269fa5e38e0c019a8f5ce9aa927f27da70f43ee Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
2016-05-10Provide a timeout for query that might run in UI thread.Marc Khouzam1-2/+7
GdbReverseToggleCommand extends AbstractDebugCommand so as to be able to block without risking a deadlock. However, this only applies to doExecute() and isExecutable(). GdbReverseToggleCommand has two other methods that use queries, and those are at risk of a deadlock: isReverseToggled() and getReverseDebugMethod(). Those queries must have a timeout to avoid any risk of deadlock. Change-Id: Ia410b8f102638965ccbf8ac9deda06dc4efc5f0d
2016-05-02Bug 492779: GdbLaunch#initialize() catches exceptions, then ignores themAlvaro Sanchez-Leon1-5/+5
Change-Id: I0d8dbdfbed2477517439466cd3f255ff8ce0fbd1 Signed-off-by: Alvaro Sanchez-Leon <alvsan09@gmail.com>
2016-04-28Bug 486955 - Add "Stop on startup" option to "Debug New Executable"Mikhail Khodjaiants4-34/+157
dialog Change-Id: I3f29453e999e19d1e045fe73bc09fd9deb164ac7
2016-04-27Bug 485107: ensure correct adapter factory is being usedJonah Graham3-0/+17
Ensure that the correct adapter factory is being used for each adapter type. Change-Id: Ibd401bb16c6320a49285cae4618a80a1bc318da3 Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
2016-04-25Bug 492304 - Fix NLS warningsAlex Blewitt2-2/+2
Eclipse warns if a String literal does not have a `//$NON-NLS-<n>$` entry at the end of the line. However, for historic or formatting reasons, many such occurrences in the CDT source have an intermediate whitespace, such as `// $NON-NLS-<n>$` Fix these so that the whitespace is removed between the // and $ characters. Change-Id: Idc12398fe6e9d619af1d0b1b73fb8b6180da223c Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-25Bug 489513 - Show registers in the traditional memory renderAlvaro Sanchez-Leon2-1/+241
Change-Id: I9ddbbeb9c8345f006004d9d2982a778d28c6d68c
2016-04-25Bug 492230 - Replace buffer.append(a+b) callsAlex Blewitt12-37/+37
When using a `StringBuilder` or `StringBuffer` to create a string message, using implicit string concatenation inside an `.append()` call will create a nested StringBuilder for the purposes of creating the arguments, which will subsequently be converted to a String and then passed to the outer StringBuilder. Skip the creation of the intermediate object and String by simply replacing such calls with `buffer.append(a).append(b)`. Where values are compile time String constants, leave as is so that the javac compiler can perform compile-time String concatenation. Ensure that NEWLINE isn't appended in such a way since it is not a compile time constant `System.getProperty("line.separator")` Change-Id: I4126aefb2272f06b08332e004d7ea76b6f02cdba Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-25Bug 489512 - Show local variables in the traditional memory renderAlvaro Sanchez-Leon6-3/+635
Change-Id: I48d633e8f6979fd91e9150856fd77fccffdee299
2016-04-22Bug 492200 - Replace StringBuffer with StringBuilderAlex Blewitt28-60/+60
There are many opportunities for replacing `StringBuffer` with `StringBuilder` provided that the type isn't visible from the public API and is used only in internal methods. Replace these where appropriate. Change-Id: Ic2f50c5b6f3c3a4eae301bb3b40fb6faed235f79 Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-19Bug 491984 - Replace .equals("") with .isEmpty()Alex Blewitt9-24/+24
In many cases a String's empty status is tested with `.equals("")`. However, Java 1.6 added `.isEmpty()` which can be more efficient since it compares the internal length parameter only for testing. Replace code using the `.isEmpty()` variant instead. Some tests for `"".equals(expr)` can be replaced with `expr.isEmpty()` where it is already known that the `expr` is not null; however, these have to be reviewed on a case-by-case basis. Change-Id: I3c6af4d8b7638e757435914ac76cb3a67899a5fd Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-18Bug 491945 - Remove new String() from expressionsAlex Blewitt1-9/+9
Replace all occurrences of `new String(expr)` with `expr` provided that the `expr` is not a byte array or a char array. Change-Id: Iecae801b83084908b60b9e146eba87550eac640d Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-18Bug 491945 - Remove new String() literalsAlex Blewitt4-8/+8
Occurrences of `new String("...")` have been replaced with a direct reference to the literal it was wrapping. Change-Id: Iefb49a009f210db59e5724e0a232dba2e13292b1 Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-18Bug 491945 - Remove new String()Alex Blewitt2-4/+4
Occurrences of `new String()` have been replaced with the equivalent `""` and additional NON-NLS tags have been inserted in where appropriate. Change-Id: I54cf71dcd0d5a92a675a71166d66949533de502b Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-16Bug 491825 - Remove primitive wrapper creationAlex Blewitt7-21/+22
Using `new Integer` and other wrapper types such as `new Character` results in potential extra heap utilisation as the values are not cached. The built-in `Integer.valueOf` will perform caching on numbers in the range -128..127 (at least) using a flyweight pattern. In addition, parsing `int` values can be done with `Integer.parseInt` which avoids object construction. Adjust tests such as `"true".equals(expr)` to `Boolean.parseBoolean(expr)`. Change-Id: I0408a5c69afc4ca6ede71acaf6cc4abd67538006 Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-15Bug 491825 - Remove uses of new Boolean and friendsSergey Prigogin1-9/+9
Change-Id: Ie358c8385c278472f3b86851f6fc219007bb9b5c
2016-04-13Bug 472765: Restore test comments post refactoringJonah Graham1-39/+76
During the testsuite refactoring that significantly improved the DSF suite (Commit 528de33113d9f38ea30ef2f44f741a631043047e) some info was lost from the code. This resurrects those comments. Change-Id: I0a11dee2dcabb0800306880fc7c6217374bc337a Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
2016-04-07Replace hard-coded versions with constantsMarc Khouzam13-47/+57
Change-Id: I8653157bd1d351eb07f58b4b404edfdaaa0e756e
2016-04-07Provide Supported and Unsupported lists of GDB versionsMarc Khouzam4-19/+38
Allow to easily run only Supported or Unsupported tests Only run Supported versions in test suites Change-Id: I0d628c8aea28dad77df7943b8b1ee18df5bb6bcf
2016-03-31CosmeticsMarc Khouzam1-11/+9
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
2016-03-30Bug 489278 - [disassembly] hover does not work for registersMarc Dumais1-2/+21
Change-Id: Idc547e93d1e1f4a4085ce0f1e846964780065043
2016-03-29Bug 488661: Simplification of reverse debugging codeMarc Khouzam10-107/+144
Most changes are cosmetics (name of local variables, javadoc, etc). The note-worthy ones are: 1- Change terminology in IChangeReverseMethodHandler to be a little clearer. This causes changes in multiple files, but it was all automated. 2- Remove ReverseDebugMethod.INVALID which was used as an error code and not a ReverseDebugMethod value. 3- In GdbReverseToggleCommand, provide a different error message if there is a failure to set ProcessTrace vs BranchTrace and tell user what to do. 4- Reworked GdbReverseToggleCommand#getReverseDebugMethod in attempt to make the code easier to understand. No actual change in functionality. Change-Id: Ibdc14faff1220e6a20319644b49e641c2101e762
2016-03-24Bug 489398 - Support memory spaces in IExpressionDMAdressAlvaro Sanchez-Leon1-5/+47
When an address is resolved from an expression, the resulting address may carry a memory space provided by the backend to associate this address to a particular memory space. The current interface for the memory space service (e.g. IMemorySpaces2) can be used to parse the memory space contained in the expression. This update adds: 1) A new API method to resolve the memory space of an IExpressionDMAddress instance 2) The use of the memory space service to attempt to resolve the memory space. Note: if there is no memory space service, the memory space defaults to an empty string, which does not affect the default behaviour i.e. when memory spaces are not used. Change-Id: Idfe5669b26f84ee4e3e78f96f229ced75e6ec5c3
2016-03-23Bug 488661 - Moving the last trace method to GdbReverseToggleCommandraddepal1-6/+22
This patch solves Bug 488661 by moving last trace method to GdbReverseToggleCommand. Since it is instantiated on a per session basis. Change-Id: Idafa196c7af36373ca08d5fc7de63024fe824c2b Signed-off-by: raddepal <ravitheja.addepally@intel.com>
2016-03-22GDB Automatic remote launch, NP Exception checkAlvaro Sanchez-Leon1-7/+14
Null pointer checks were missing in GdbLaunch e.g. to cover the case when the instance is not fully initialized e.g. invalid gdbserver path. Change-Id: Ie5b593417aa831cb5b35b19f31d2b0a03b1fdc86 Signed-off-by: Alvaro Sanchez-Leon <alvsan09@gmail.com>
2016-03-22Don't require gdbserver to be present for local tests to passMarc Khouzam1-15/+71
The TraceFileTest.java file has three tests which depend on each other. Inter-dependency between tests is not good. This commit removes it. Change-Id: Id910a5cea741c85959679e4b0a6981f603f19d13
2016-03-20Bug 489777: Remove method returning thread as intsMarc Khouzam2-22/+3
Method MIThreadListIdsInfo#getThreadIds() has been removed. MIThreadListIdsInfo#getStrThreadIds() should be used instead. Change-Id: Id6fb924a96b193012eaae0c8811b386873cd411c
2016-03-20Bug 489777 - [API] Replace thread id type from int to StringAlvaro Sanchez-Leon29-162/+218
in preparation for the introduction of thread groups syntax in GDB, thread id needs to be handled as a String. Change-Id: I379a92de9755ba0532265519ee70d1e199de811b
2016-03-19Bug 472765: use Strings for backend path in Map EntriesJonah Graham4-14/+135
Preserve the user supplied backend path as a string so that it matches what GDB (backend) later reports as a file name to resolve. Condensed history: Traditionally in source mapping container, the backend path was stored as an IPath and that was used to compare against the debug information being returned by GDB. This worked well when the platform compiled for matched the platform run on, but when there was Windows/Linux together that did not work. So as part of Bug 393791 a workaround was done to try and use hand crafted MapEntrySourceContainer.createPath() instead of Path constructor to preserve some of the differences. This solution had its limitations too as UNC paths still could not be represented, See open Bug 386675. Change-Id: I4c8f62114a2c6019dc9d07ce446ac424be8b230c Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
2016-03-19Bug 488950 - Remove "New..." button from 'Connect' dialogueMarc Khouzam6-126/+15
Change-Id: Ia60e7a9e1e6d211bbe4c137f3ff5f7368ab68e83
2016-03-19Bug 489683 - Fix typo while changing APIMarc Khouzam1-5/+5
Change-Id: I1e5e5f92564c486e2f14da9a7f3a4e15598ba069
2016-03-19Bug 489683 - Change the breakpoint "number" from an int to a StringMarc Dumais32-311/+337
Change-Id: I33a8ca95f6894c360c95260433945cdf1b529bc3
2016-03-19Support -Dcdt.tests.dsf.gdb.versions=all for gdb testsAlena Laskavaia1-1/+6
Change-Id: I7b0921f3dfc41e75f2f32b270712c0eda7fc96a4
2016-03-19Fix version range check in SourceLookupTestJonah Graham1-4/+2
Change-Id: Ief38312449c67073c6a6503f27807b455fa4066c Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
2016-03-18Bug 489216 - [memory view] memory space sometimes wrongly set, duringMarc Dumais1-6/+7
the restoring of memory monitors Change-Id: Iab8554aef0ca24d2643440f1ba845eb253e29676
2016-03-18Flattening rest of gdb testsAlena Laskavaia345-11537/+1786
this commit removes and merges rest of gdb tests in favor of using parametrized tests Change-Id: I352545c2ea3d76154c8079f8efa9aa5d4a3e0032
2016-03-18Bug 472765: Add extra sourceLookup testMarc Khouzam1-0/+38
Change-Id: I98c11a2f4e231d6bc0e0bb53ea1e0b3465c9a976
2016-03-17Bug 488909: Unify services factory classes to extend more easilyMarc Khouzam6-86/+27
From org.eclipse.cdt.debug.gdbjtag.core, constructor GdbJtagDebugServicesFactory.GdbJtagDebugServicesFactory(String) has been replaced by GdbJtagDebugServicesFactory.GdbJtagDebugServicesFactory(String, ILaunchConfiguration) From org.eclipse.cdt.dsf.gdb, constructor GdbDebugServicesFactory.GdbDebugServicesFactory(String) has been replaced by GdbDebugServicesFactory.GdbDebugServicesFactory(String, ILaunchConfiguration) From org.eclipse.cdt.dsf.gdb, class GdbDebugServicesFactoryNS has been removed and its logic was merged into class GdbDebugServicesFactory Change-Id: Ifecba752cfc12da62f1447027b11c0bb1f7c0171
2016-03-17gdb catchpoints registers tests cleanupAlena Laskavaia67-834/+207
Change-Id: Ibea6071b9b8e07f63508e177fabf8e60da5c0a08
2016-03-17Bug 472765: Use gdb's "set substitute-path from to"Jonah Graham12-58/+906
Add support for gdb's "set substitute-path from to" by adding a new service called GDBSourceLookup that uses GDB to perform the path mapping. The new GDBSourceLookup service uses the new GdbSourceLookupDirector to get the set of paths that need mapping using GDB's "set substitute-path" and the director resolves compilation path differently so as to leave the GDB backend to handle the local path to compile path resolution. The MappingSourceContainer has been enhanced to allow a per mapping container override of the new behaviour. This is a fallback as the default behaviour when using GDB is to use "set substitute-path". The MappingSourceContainerDialog exposes the new option in MappingSourceContainer as a checkbox at the bottom of the path mapping dialog in a backend agnostic way. The new code is tested in methods called "sourceSubstitute*" and mirror the same tests for the now non-backend handled version which are "sourceMapping*". Note that doMappingAndLaunch/doSubstituteAndLaunch have been updated to explicitly check or uncheck the setIsMappingWithBackendEnabled setting Change-Id: I122d7c597cd461d8e38c4f82522ccfdf9e51a5ba Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
2016-03-16parameterized tests gdb testsAlena Laskavaia57-1797/+1297
this commit to introduce a test harness that allow to reduce SIGNIFICALLY duplication of test per gdb version. Tests is now parameterized with version and type (gdb vs gdbserver). This commit flattens on of the tests as example rest is still using an old way. Parameters are defined externally now via Java variable like this -Dcdt.tests.dsf.gdb.versions=gdb.7.7,gdbserver.7.7,gdb.7.11 Change-Id: I855449afba40e265c542dc5de7a3562548c97e8b
2016-03-16Bug 489455 - Add new breakpoint action to run arbitrary debugger commandAlena Laskavaia2-0/+91
This is generic support for debugger commands though mi console bridge, should be not gdb specific (have a simple gdb implementation though) We add new breakpoint action called "Debugger Command" Interface allows to enter arbitrary string(s) This is interpreted by debugger as it see fit For gdb implementation these are cli commands Change-Id: I20ca0b8b094c724e1cf8b0691f4f6cab84a3737d
2016-03-15adding repeater to some intermittent testsAlena Laskavaia2-7/+29
Change-Id: Idd1610e9c753951a974e336a65441b752e667e00

Back to the top