Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/core/org.eclipse.cdt.core/src/org/eclipse
AgeCommit message (Collapse)AuthorFilesLines
2018-11-22Bug 540373: Remove '(non-Javadoc)' commentsJonah Graham6-100/+0
These were inserted in the past automatically by Eclipse but newer tooling makes them redundant. These were removed by doing a global find/replace on *.java files using the following regular expression: \t/\*\n\t \* \(non-Javadoc\)[^/]*/\n Change-Id: I59d3248020f10934fde1dda5b5a31e20bb188e19
2018-11-22Bug 540373: Cleanup: Remove redundant type argumentsJonah Graham33-98/+98
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Remove redundant type arguments and completing the wizard Change-Id: Iaecc7010f097b4b1fabd29ccaa34ccb23a716fbf
2018-11-22Bug 540373: Cleanup: Organize ImportsJonah Graham3-4/+3
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Organize Imports and completing the wizard Change-Id: Ia7b305a4c967d0e6f4e8fb8c1041e7028b24006c
2018-11-22Bug 540373: Cleanup: Format & Remove trailing whitespaceJonah Graham200-10073/+10641
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Format source code - Remove trailing white spaces on all lines and completing the wizard Change-Id: I63685372c6bcc67719bcf145123bcb72e5b00394
2018-11-22Bug 540371: Update to EPLv2 using releng/scripts/change_to_eplv2.shJonah Graham223-669/+1338
Change-Id: Ifbb1d5af2a00bd5634dea200320e8c4303ffca6c
2018-11-20Bug 540373: Normalize newlines with .gitattributesJonah Graham3-446/+446
There is also a new script to verify completeness of .gitattributes: releng/scripts/verify_gitattributes.sh Change-Id: I2ce270852ab54b66b6c474a6ec94203fe5bba78b
2018-10-22Bug 529656 - Error if docker build failedHannes Vogt2-0/+5
If the build command in a container build terminates with non zero exit code (e.g. make command not found) an error is displayed. Change-Id: Ib6349aa6c22c1a3bb9c0d2920110bc69773f8da1 Signed-off-by: Hannes Vogt <hannes@havogt.de>
2018-10-12Bug 540085 - Deadlock in ToolChainManager initJeff Johnston1-1/+1
- modify ContainerGCCToolChainProvider.init so that the CBuildConfigurationManager.recheckConfigs() call is done within a separate job so the init() call will return without causing deadlock - do the same for ContainerTargetTypeProvider - modify CBuildConfigurationManager initProviders() method to be synchronized Change-Id: I4ca9371fb340887233872b6d315621a24450fb2b
2018-09-27Bug 512822: "Launch failed. Binary not found" even after buildingHansruedi Patzen1-41/+14
Builds upon https://git.eclipse.org/r/#/c/92129/ but also uses the hints to only read the file if necessary. I further reverted some of the changes done with the patch for 'Bug 510987 - Properly support PIE executables as build output' since the binary will now be seen as an executable anyway. Change-Id: I075fef67f3b101ddbc64786dcbc2ca41cc114e25 Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch>
2018-09-12Bug 536884 - Removing header cache should cause ScannerInfo refreshJeff Johnston1-3/+0
- don't reset setting in shutdown() method as this clears the property prematurely for meson and cmake projects Change-Id: I2dd2467427d00aeade335319ec2ceec9f6d7168d
2018-07-12Bug 536884 - Removing header cache should cause ScannerInfo refreshJeff Johnston1-2/+32
- add a new IToolChain property "cdt.needScannerRefresh" that is set if scanner info needs to be refreshed - for a Container build, turn the property on in ContainerGCCToolChain startBuildProcess() if the Container headers for the toolchain's have been deleted - in CBuildConfiguration processLine(), look for the toolchain property when looking to see if scannerinfo should be calculated - in CBuildConfiguration, turn the toolchain property off in shutdown() Change-Id: I67a3537d1e2967dc15b66a1c37abda1ae8f78bff
2018-06-21Bug 535274 Follow up cosmeticsThomas Corbat1-6/+7
Change-Id: I562bc0925e53a461bd9e6362dc14f2e1cd924582 Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
2018-06-20Bug 535256: Rewrite removes attributes, key and base from C++ enumHansruedi Patzen1-0/+15
Fix and tests. Change-Id: I1f5519f833563378d87b3c932b754e29c3e32b06 Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch> Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
2018-06-20Bug 535274: Allow attributes on namespace definitionsHansruedi Patzen1-5/+27
Implementation and tests. Change-Id: I0cca9dea8630ae66b005856338342b4173c48216 Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch> Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
2018-06-15Bug 535278: Formatter error formatting CF statements with attributesHansruedi Patzen1-0/+14
Fix and tests. Change-Id: I1928d5fe70c02cbc9c147bb305720ad75b4913fc Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch> Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
2018-06-15Bug 535263: Switch statement attributes lost on rewriteHansruedi Patzen1-1/+4
Fixed with the patch for 533552, only the CodeFormatter needed fixing. Change-Id: I258617d01b091764ad9776921e773e208002c989 Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch> Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
2018-06-15Bug 535331: Rewriting sizeof...() drops the parenthesisHansruedi Patzen1-3/+1
Fix and test. Change-Id: If54f24d833724f3c51ae0b6e7f325493e5110719 Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch> Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
2018-06-15Bug 535266: Formatter error CaseStatement with attributesHansruedi Patzen1-0/+2
Fix and test. Also fixes formatting errors with DefaultStatements. Change-Id: Idac4a7105d7ae86db40755bd27cef60e197de664 Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch> Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
2018-06-14Bug 533552: Rewriting nodes with attributes causes attribute duplicationHansruedi Patzen1-0/+38
Fix and tests. Also fixes bug 535265, since the Codan Quickfix tests fail otherwise. Change-Id: Id31e40907b7ebdeee4a67c014c3a1b1cd37579ad Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch> Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
2018-06-03Bug532849 Inline namespace not recognized by formatterHansruedi Patzen1-0/+6
Change-Id: Ie7f13884967685fcc93c8af3955d90825d6f9879 Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch> Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
2018-05-28Bug 535139 - Container target set-up causes NPEJeff Johnston1-11/+13
- add null check before accessing ordered tool chains Change-Id: I713a55f8e887b642aa4a159e59c454de9a97955a
2018-05-03Add dynamic variable for build directory of active core build configDoug Schaefer3-0/+65
This will allow us to use that value in external tool launches such as those used by the Serial Flash launch configuration. Also removal of the missing src source folder entry in meson.ui.editor. Change-Id: I1033bdc0c18c9822490a9b8602cef83a42f7262d
2018-04-26Bug 533888 - Simplify Meson Core Build to use startBuildProcessJeff Johnston2-13/+39
- fix MesonBuildConfiguration to use startBuildProcess instead of CommandLauncherManager - change CBuildConfiguration startBuildProcess() method to accept a build directory and to replace environment variables based on input parameter - fix CBuildConfiguration watchProcess routines to ensure that the ReaderThreads have completed processing output to the console - change StandardBuildConfiguration and CMakeBuildConfiguration to pass the working directory to startBuildProcess Change-Id: Icb4f2d076f0e6bb1513b20f6f198f720eae07e51
2018-04-20Bug 533842 - Fix Launchbar for enabled/disabled Docker ConnectionsJeff Johnston2-1/+79
- fix CMakeBuildConfigurationProvider to not verify if a toolchain file exists which doesn't occur for Container Build configurations - add new ICBuildConfigurationManager2 interface that adds new recheckConfigs() method, make CBuildConfigurationManager implement this new interface - add new recheckConfigs() method to CBuildConfigurationManager so that if a Docker Connection is enabled, the list of invalid configs can be rechecked and those that are now valid can be removed from the noconfigs list - have ContainerGCCToolChainProvider implement IDockerConnectionManagerListener and register itself as a listener during init - add new changeEvent() method as part of a listener that will add toolchains for connections that are added/enabled and similarly will delete toolchains for connections that are removed/disabled - do the same with ContainerTargetTypeProvider (making it be an IDockerConnectionManagerListener and adding/deleting targets based on whether a Docker Connection is added/enabled or deleted/disabled - as well during the init process of ContainerTargetTypeProvider remove any targets for Connections that aren't established Change-Id: Id5e9415eaa770ef7f6ba1ddd11312ed003585391
2018-04-16Bug 533222 - Add Container Build support to Std Make Core BuildJeff Johnston7-41/+177
- add new getConsoleHeader() method to ICBuildCommandLauncher interface and ContainerCommandLauncher class - modify MakefileBuildConfigurationProvider to create build configurations based on an Image name when building for Container and as well support the linux-container os that is used for Container targets - add new IConsoleParser2 interface that extends IConsoleParser and adds new processLine method that takes a List of Job as a parameter - make CBuildConfiguration implement IConsoleParser2 and add new processLine method - modify watchProcess to recognize an IConsoleParser2 and pass a Job List then wait for all jobs to finish before calling shutdown() and possibly reindex - add new IToolChain2 interface with startBuildProcess() method - add new startBuildProcess() method to CBuildConfiguration to look for new IToolChain2 and use its startBuildProcess() method to perform the build - make ContainerGCCToolChain implement IToolChain2 and add new startBuildProcess() method to build in Container - change StandardBuildConfiguration to use startBuildProcess() to do build and clean Change-Id: Icae9a55ef6abfa1b7f611544ad591b6062c72585
2018-03-20Replace refreshScannerInfo with setActive methodJeff Johnston2-5/+15
- remove the refreshScannerInfo method from ICBuildConfiguration2 but add it as a protected method of CBuildConfiguration - edit MesonBuildConfiguration and CBuildConfiguratio appropriately - add new setActive method to CBuildConfiguration which calls refreshScannerInfo Change-Id: Iebae09507f24293007a299eea3069451e566a91b
2018-03-20Bug 532420 - Make Container Core Build indexing more efficientJeff Johnston5-40/+201
- add new ICBuildConfiguration2 to keep API checks happy - remove refreshScannerInfo method from ICBuildConfiguration and put it in ICBuildConfiguration2 - make CBuildConfiguration implement ICBuildConfiguration2 - update ContainerPropertyVolumesModel to use new Docker plug-ins using docker-client 8.9.2. - fix MesonBuildConfiguration to use a job for each compile line being processed, then wait until all jobs are done before causing an reindex to occur (this will maximize parallelism when building in Containers) - fix ContainerCommandLauncherFactory to save the project so we can exclude project directories when copying header files using the new Docker Tooling interfaces - fix CoreBuildLaunchBarTracker to use ICBuildConfiguration2 interface to make the call to refreshScannerInfo Change-Id: I2138f5111614e7821e46c22731397a01035eac0a
2018-03-11Bug 532209: Run extensions in SafeRunnersJonah Graham1-7/+9
Change-Id: Icf748b9769c7a454cf3bc4b4a27fff896ce38086
2018-03-07Bug 531991 - Fix command launcher manager priority comparisonChin Huat Ang1-3/+9
When iterating through a list of command launcher factory to select the highest priority factory, be sure to compare using the last known highest priority. Change-Id: I473ac9c8ff7cfb5a0aa81714101a795816fd1ac8 Signed-off-by: Chin Huat Ang <chin.huat.ang@intel.com>
2018-03-06Bug 531985 - Support Container build with new Core BuildJeff Johnston4-0/+56
- add new ContainerTargetTypeProvider to create a new target for each usable Docker image from known connections - add new ContainerGCCToolChain class which supports gcc in a Container for projects with Container targets - add new ContainerGCCToolChainProvider which creates a ContainerGCCToolChain for each usable Docker image from known connections - add new CoreBuildContainerLaunchConfigProvider class - add new CoreBuildContainerLaunchDescriptorType class - add new ContainerTargetLabelProvider class to support adding a new Container target - add new NewContainerTargetWizard and NewContainerTargetWizardPage to add/edit a new Container target - add new IContainerLaunchTarget class - add new refreshScannerInfo method to ICBuildConfiguration interface to allow switching ScannerInfo when target is switched - implement default refreshScannerInfo method in CBuildConfiguration which currently does nothing - add new fetchContainerDirs method to CommandLauncherManager to fetch container directories for a project that is using Core Model and CBuildConfigurations - add new verifyIncludePaths method to ICommandLauncherFactory2 that takes an ICBuildConfiguration and implement this for ContainerCommandLauncherFactory - fix ContainerCommandLauncher command handling to use a list of Strings to preserve spaces in arguments and call new runCommand interface in Docker UI...as well do not link any args that are files if they are system directories (e.g. /usr /bin) - fix getCommandLauncher in ContainerCommandLauncherFactory when passing an ICBuildConfiguration so that it uses the configuration's toolchain properties to figure out if a Container build is asked for - fix launch method of ContainerLaunchConfigurationDelegate to check if working directory is null in which case use the project directory - also add buildForLaunch method override and preLaunchCheck to ContainerLaunchConfigurationDelegate so it can be used for Core Build launching as well and ensure that the project name and active configuration is set properly - in CoreBuildLaunchBarTracker, use the lastTarget to set the active target instead of the local field "target" as this will end up setting a random target as the active target. Also call the new refreshScannerInfo method of the build configuration when the active target has changed - add ICBuildConfiguration support to Docker LaunchShortcut such that properties will be set appropriately and acquired from the toolChain - bump up Docker launcher version to 1.2.0 Change-Id: I074b02314f6ac6942fdf230b1dc8e154ced3088e
2018-03-01Yet another deadlock in old ICDescriptor code.Doug Schaefer1-13/+19
Hitting this in our internal verify jobs. This invoke method locks the element then calls removeProjectStorage which waits on fLock. Meanwhile someone else has called getProjectData has the lock and then tries to lock an element. Deadlock. Change-Id: I5d013e8aa3c16e8c832fbe30b2dd3c17aeeefee5
2018-02-15Fix up handling of esp32 on Windows.Doug Schaefer1-1/+1
Need to convert paths from MSYS style to proper Windows native. Change-Id: I8c459274a1eb33af026c1ae383db67c8cbcdc29f (cherry picked from commit fea65eeb1590dd593fcc7e66d5e5ba9d59df26df)
2018-02-15Bug 531098: [C++17] Add support for switch with initializerHansruedi Patzen1-9/+30
Change-Id: I046acd311cb99215798d2cbb8d30c2ef8ff2301d Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch>
2018-02-14Bug 531125 - Tupled gcc toolchains should not be the local defaultJeff Johnston1-1/+2
- change ToolChainManager so that when creating the types map for the first time, make it a LinkedHashMap instead of HashMap so order of input is preserved (first in = first out) - fix GCCPathToolChainProvider so that it adds non-tupled gcc to the ToolChainManger before adding any tupled version Change-Id: I84602a98dd4949a2f9847d4e72c428cdedd60688
2018-02-13Bug 522216, 527427: [C++17] Support for constexpr if and init-statementsHansruedi Patzen3-21/+46
Change-Id: Ia8195c66334edb107848901619e85fbfb5c78b18 Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch>
2018-02-13Bug 531071 - CBuildConfiguration doesn't handle quoted argumentsJeff Johnston1-4/+59
- fix CBuildConfiguration processLine() to call new stripArgs() method to parse the command arguments into separate argument strings and recognize quotes Change-Id: I759fb94600b82a55bf5e7f179e01e1f976ce193f
2018-02-13Bug 531043 - Display errors/warning count for makefile & cmake buildsWilliam Riley2-4/+5
Change-Id: I8b2ab525af137ddd890f5713a3278cce6d17bffd Signed-off-by: William Riley <william.riley@renesas.com>
2018-02-13Bug 531043 - Add missing since tags to new API in EPMWilliam Riley1-0/+6
Change-Id: I14c270de6e4d9322b076a97236fceeb6f4dc2f92 Signed-off-by: William Riley <william.riley@renesas.com>
2018-02-12Bug 531043 - Display number of errors/warning as end of buildWilliam Riley3-5/+33
Changes to ErrorParserManager & implementation of message for legacy build system. Change-Id: Iffc34eeae87bbd2810684fc52a9d9bcd4bb47950 Signed-off-by: William Riley <william.riley@renesas.com>
2018-02-12Fix newlines.Jonah Graham1-615/+615
Change-Id: I78acc1c843d58a5e1f69db6ea68a6c6dda34198b
2018-02-08Remove useless imports.Alexander Kurtakov1-2/+1
Change-Id: Ie59d3942ea1df97440bd84e46a24753ed6ed429b Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-02-02Bug 529121 - "Build target" has stopped working in CDT 9.4.0Jeff Johnston1-1/+3
- default environment using EnvironmentReader in CommandLauncherWrapper class in CommandLauncherManager if no environment set for wrapper to match behaviour of CommandLauncher Change-Id: I71ff37b3d8f2049dc705e97bf28f939ac78bd390
2018-02-02Fix some API issues caused by some recent CommandLauncher additionsJeff Johnston4-15/+41
- remove new exposed field from CommandLauncherManager and add correct @since tags - create new ICommandLauncherFactory2 interface so that no additions are made to ICommandLauncherFactory - add @since tag for ICBuildCommandLauncher interface - make ContainerCommandLauncherFactory implement the new ICommandLauncherFactory2 as well as ICommandLauncherFactory Change-Id: I7bbacb59e284b43e6d142accf59b6ab9df274438
2018-01-29Bug 530468 - Support passing CBuildConfiguration to Cmd Launcher FactoryJeff Johnston3-0/+68
- add new ICBuildCommandLauncher interface - add new defaulted method to ICommandLauncherFactory interface - add code to look at Build Configuration properties in ContainerCommandLauncherFactory - add new methods to CommandLauncherManager and ContainerCommandLauncher - add an update dialog call in ContainerTab - add calls to set and get CBuildConfiguration to ContainerCommandLauncher Change-Id: If95fafe592c7ea4580bae1a15d168d1163e132fd
2018-01-08Bug 529023 - Cannot set build.proj.ref.configs.enabled via customizationSimeon Andreev1-2/+13
The setting build.proj.ref.configs.enabled=true ensures CDT projects are not rebuilt if non-related projects are changed. This setting cannot be changed with product or command line customization, hindering products which require this behavior. The reason for this is that ACBuilder, which is asked for the value of the preference, communicates with the instance scope of preferences. Product and command line customization, however, are on default scope level. With this change, ACBuilder will also ask the default scope when retrieving the value of the preference. Change-Id: I09e895ea2a05b677e36fac9eb28f24f1f3bc2877 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2017-12-12Bug 528124 - NPE in CCOdeFormatter.findOverlappingPreprocessorStatement()Nathan Ridge1-0/+3
Change-Id: I4669d4938551506d7a06624b4318253cc4ecc643
2017-11-28Info cache files were not getting deleted properlyDoug Schaefer1-2/+2
When deleting projects then creating them with the same name the scanner info didn't get cleared up and was reused. We were deleting these files from the wrong path. Change-Id: Ieda174b7cfc9690ab51be65e674bda321cb3bc10
2017-11-27Stop launch on error. Fix up set/get make commands.Doug Schaefer3-21/+48
We were missing the dialog to ask if you wanted to continue after build errors in a project. We were missing the method that provided the list of projects to do that check. Also while testing that noticed the handling of the build and clean command UI was broken with make projects. Change-Id: I698e151672a114bb22c815f49d362b6413b9c315
2017-11-22Hook up the old Include Paths and Symbols page to Makefile projs.Doug Schaefer2-4/+111
Makefile projects depend on build output parsing to pick up compiler options to use while indexing. Sometimes, that just doesn't work. As a back up we've always allowed users to manually add them to the project. Long ago when we had pure make projects we had UI for this. This change hooks that old UI up. It was a time before build configs so they get applied to them all but it serves it's role as a backup when users run into problems. Unmarked everything I use here from deprecated until we decide how to replace these with Core build config aware settings. Change-Id: I6fc4d48e5315df3c60c7591b026ae0a53a1f505e
2017-11-21Undo the fix I did for creating the build container.Doug Schaefer1-18/+7
It cause more problems than it solved. Will need to revisit later. Change-Id: Ifbbb2a29c41f24ff08e1debb03ee5f4739d0223b

Back to the top