Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2017-12-01Fix version of serial launch feature.CDT_9_4_0Doug Schaefer1-1/+1
Change-Id: I850f72c9b094f732e384596c05ed30485bd2fceb
2017-12-01Fix up license field for serial launch feature.Doug Schaefer2-5/+11
Change-Id: I26534c7748186428af908111dc712cd0c0d09708
2017-12-01Fixes for ESP32.CDT_9_4_branchDoug Schaefer2-3/+14
In the new toolchain wizard, the select button wasn't hooked up. So I turned it off. Also, we had no build settings tab on the serial launch. Change-Id: I811f579334889085f49d298878589109c5e4a228
2017-12-01Cleanup Core Build Preference pages.Doug Schaefer8-8/+19
Move Toolchains directly under C/C++ and rename to Core Build Toolchains. Add a label describing what the toolchains are for in hope of avoiding confusion with managed build. Also move Qt into C/C++. Change-Id: Ia1d76087c65b26562d1001243ea355c7ac32365e
2017-12-01Fix issue with core build launch desc deletion.Doug Schaefer2-49/+2
When projects were deleted, sometimes the descriptors would not. We were creating our own core build launch descs which didn't have an equals method causing duplicate entries to be created. Arduino uses launch bar's project launch descs. This change does the same for core build. Change-Id: I2a6f60e92aaa20892d6c1d8331ded903b226984f
2017-12-01Bug 527697 - Size of parameter pack where arguments themselves contain a packNathan Ridge2-1/+28
Change-Id: I850eaf74a3fb3ec4b160aedc3f594ff0d0edf31a
2017-12-01Bug 527959 - Fix argument lists for some builtinsMartin Oberhuber1-12/+14
- Add volatile variant for __atomic_clear and __atomic_test_and_set - Add missing parameters for __builtin_fmax and related Change-Id: Ib31d1a410b8749f5672d70d7d02ca1dff962c38b Signed-off-by: Martin Oberhuber <>
2017-11-30Bug 527553: Detect invalid decltype(auto) with a type specifierHansruedi Patzen7-0/+296
The evaluated type of 'decltype(auto)' in combination with const and/or volatile will be a ProblemType since this is not valid code. The patch also contains a checker to give the user a visual feedback. Note: A proposed quick-fix has been removed after a short discussion. Change-Id: I8760ed0ac28e28529ab30516accac9c0413c87d9 Signed-off-by: Hansruedi Patzen <>
2017-11-30Bug 515305 - Fix 32-bit serial port dllDoug Schaefer2-1/+1
It was depending on the libgcc dll. Changed to link it statically. Change-Id: Ifd8610c78d3861f3c4cd82fde3bb47f5c3afe594
2017-11-29Fix manual include/macro settings handling for GCCToolChain.Doug Schaefer1-8/+31
We weren't passing in the base settings to the compiler for discovery. Also had a bug in the defines regex that mishandled values with spaces in them. Change-Id: I48183bfc3f61056324da009e58327cdcfed8754a
2017-11-28Info cache files were not getting deleted properlyDoug Schaefer1-2/+2
When deleting projects then creating them with the same name the scanner info didn't get cleared up and was reused. We were deleting these files from the wrong path. Change-Id: Ieda174b7cfc9690ab51be65e674bda321cb3bc10
2017-11-28Bug 527872: UDL operator name gets duplicated on rewriteHansruedi Patzen2-6/+9
Change-Id: Id1cda5f09f6fc3852a99a607be21f6ea33f5faf5 Signed-off-by: Hansruedi Patzen <>
2017-11-27Stop launch on error. Fix up set/get make commands.Doug Schaefer7-28/+94
We were missing the dialog to ask if you wanted to continue after build errors in a project. We were missing the method that provided the list of projects to do that check. Also while testing that noticed the handling of the build and clean command UI was broken with make projects. Change-Id: I698e151672a114bb22c815f49d362b6413b9c315
2017-11-27Bug 527818 - Clean up handling of missing toolchain fileDoug Schaefer4-1/+22
If we're building for non-local targets we need a toolchain file. Print out an error message when it's missing at build time. Recover when one is added. Also a rider that makes sure the Makefile projects are marked experimental. Change-Id: I0c295dc5b3d71a04c60c3385ce790553f172859d
2017-11-27Bug 444054 - Make sure we build the right projectDoug Schaefer1-0/+3
The call to CDTBuildAction's super updateSelection method clears out some state. Make sure we call it even though we want to always build CDT projects. Change-Id: Ie5dc1f583bbcc04d85b7254a4b7c18ee50f02997
2017-11-24Bug 527396: Parser includes curly brace when parsing noexcept functionsHansruedi Patzen2-4/+58
Change-Id: I0d2626cccf5b093f2f3cc9fbcbeaedbb21ebd508 Signed-off-by: Hansruedi Patzen <>
2017-11-24Bug 527709 - [Checker] Test suite fails on WindowsHansruedi Patzen3-2/+8
Change-Id: I70cf18245dc8dba14493f212c932ea08ae85a6cf Signed-off-by: Hansruedi Patzen <>
2017-11-23Bug 444054 - Always enable the build actions.Doug Schaefer1-0/+6
If you select a non-CDT project then select a CDT one, the Build Project menu item wouldn't enable. If you select the CDT project again, it does. Big question is why isn't it enabled when selected. This fix just enables it all the time. Much easier for users to understand. Change-Id: I674740f2c6998686cade1f910a269a4e9d935d39
2017-11-22Hook up the old Include Paths and Symbols page to Makefile projs.Doug Schaefer29-152/+155
Makefile projects depend on build output parsing to pick up compiler options to use while indexing. Sometimes, that just doesn't work. As a back up we've always allowed users to manually add them to the project. Long ago when we had pure make projects we had UI for this. This change hooks that old UI up. It was a time before build configs so they get applied to them all but it serves it's role as a backup when users run into problems. Unmarked everything I use here from deprecated until we decide how to replace these with Core build config aware settings. Change-Id: I6fc4d48e5315df3c60c7591b026ae0a53a1f505e
2017-11-21Bug 526669 - Use the Matcher API correctly in ↵Nathan Ridge1-0/+2
CodanProblemMarkerResolutionGenerator Change-Id: Ia47cabea736fe2965f60117ae2074b6e2212d917
2017-11-21Releng fixes, ensuring legal files are there. Removing projects.Doug Schaefer37-340/+257
Removed the empty debug.core.tests project. Also removed the utils-feature and remote-feature projects since these shouldn't be features. Change-Id: Ib5d297c626de5328e3421a1fc9346330d9907750
2017-11-21Add the Launch over Serial Flash feature to the repo.Doug Schaefer1-0/+6
Change-Id: I76283cb28ef48f8bc777c91decf1e8289e878a83
2017-11-20Undo the fix I did for creating the build container.Doug Schaefer1-18/+7
It cause more problems than it solved. Will need to revisit later. Change-Id: Ifbbb2a29c41f24ff08e1debb03ee5f4739d0223b
2017-11-20Set CC and CXX variables to toolchain compileCommands in std build.Doug Schaefer5-18/+75
Also set BUILD_MODE to the launch mode so the makefile can do different things based on the mode. Change template to add -g option for debug. Also fix a deadlock I detected due to side affect build folder creation. Change-Id: Ic7b13ba3238e6ef201cccb1b2bfc8dcc6956ea3a
2017-11-20Fix MSYS2 so that it's provider overrides the path provider.Doug Schaefer2-2/+13
Also handle case when launchMode is null when creating a build config. Change-Id: Ie70de785168c2e24c842d517c64a297ba44e24f4
2017-11-19Expose org.eclipse.cdt.docker.launch directory as publicJeff Johnston6-4/+9
- move ContainerCommandLauncher to org.eclipse.cdt.docker - update DockerLaunchUIPlugin to be noextend - update users of ContainerCommandLauncher appropriately Change-Id: I32ea6de3b3df12b6579249583303111bf6b7b957
2017-11-18Bug 527419: Process async output with no variableJohn Dallaway1-8/+12
Change-Id: I4deb2b9db4421016b27e01353b0ae4745b139361 Signed-off-by: John Dallaway <>
2017-11-17Forgot to add the makefile templates to the build.Doug Schaefer1-1/+2
Change-Id: I538e8610f9e31963a2c8224079de1a2f19c565c3
2017-11-16Fix missing recording of launch mode for core build configs.Doug Schaefer1-0/+1
Was causing new build configs to be created for non "run" mode configs. Change-Id: I6b939ac1da9fcf6678bf28b0bbad201fc723b371
2017-11-15Fix up leftover toolchain provider id usage.Doug Schaefer2-2/+2
The CMake toolchain file editor was not recording the correct toolchain. The same was also true for the toolchain selection in the build settings tab. Change-Id: I62e4c7ae0175da7c1b5ffb7f89e321a371a6e8e0
2017-11-15Bug 526975 - Deduce return type correctly in the presence of multiple return ↵Nathan Ridge3-46/+93
statements The previous implementation deviated from the C++ standard by checking that the types of the return expressions are the same, rather than the return types after deduction against the placeholder type. There was also a bug in the return type deduction code for lambdas, where for a lambda without an explicit placeholder in the trailing- return-type, the deduction process wouldn't be performed. Change-Id: I2f0b9f1c7778aef60e4cd7ada9386b99be52669a
2017-11-15Bug 500988: better handle race condition in SourceContainerJonah Graham1-1/+31
Instead of an indiscriminate NPE at termination of a launch, handle it more cleanly with a friendly error message. Change-Id: Ie37e675c3f5e4883c0b160bfe86c4848f1983fa7
2017-11-15Bug 527179: ExpressionWriter removes nested noexcept expressionsHansruedi Patzen2-2/+32
Change-Id: I7c032e9327756704690760f3207c73f1645deb19 Signed-off-by: Hansruedi Patzen <>
2017-11-14Bug 526857 - Diagnose member access into pointer type in C codeNathan Ridge3-1/+21
Change-Id: Ib6fc6be443d59facacde3c290e0f974e5cbe6f1b
2017-11-14Bug 519533: Fix scroll lock on build consoleJonah Graham1-1/+3
Change-Id: Ib7826de6ed26dbd05f2568d097deb52cf3dc4768
2017-11-14Bug 525675: Fix dependency versionJonah Graham1-1/+1
The o.e.c.debug.ui uses some internals in o.e.ui.ide that only existed in Oxygen and greater. Bug 516470, which should be fixed for Photon will mean these internals can be removed. Change-Id: If0fbd186a8d6b77a6cb6b8a9d231c784b45cb88d
2017-11-14Bug 525675: Delegate opening unknown file types to unknownEditorStrategyJonah Graham4-27/+43
This code enables the Debug view in CDT to take advantage of: Change-Id: I35e0453ce7ee772aac33ffbce6e66926bbb475e3
2017-11-13Serial Flash Target and Launch. Clean up Generic Launch.Doug Schaefer46-162/+2052
Adds target, launch classes, and launch bar support for targets intended to upload their code to flash using a Serial Port. The port is co-ordinated with the Serial Terminal so that the terminal is paused during the upload. Also cleaned up the Generic Launch so it's not using the External Tools launch which has a number of UX issues. This simplifies the settings and gives us more control. And it's made reusable for the Serial Flash launch. Change-Id: I31e9970243fbf1cf22d027bbdb892fde104dbefe
2017-11-13Bug 514363 - Fix constexpr evaluation of assignment into array elementNathan Ridge2-1/+26
The computation had a bug where the array decayed to a pointer, and we tried to use the pointer's value as a composite value, instead of the underlying array's value. Change-Id: I9510d28e04deb0b8ef835e2857f8b513d11d1d72
2017-11-13Bug 522010 - Completion of non-type template parameter in ambiguous template ↵Nathan Ridge6-11/+111
argument This works around the fact that the optimization introduced in bug 316704 inteferes with the mechanism for offering completions for both alternatives in an ambiguous context. Change-Id: Ibe14c1b4f2f9c9b3394d4635c87424a25fbd7a53
2017-11-13Bug 520580: Implement new-console support on WindowsJonah Graham13-38/+258
A new checkbox on Windows only that starts inferiors in new window. Change-Id: If3efbe5e6b037e3b1c9528eed67068088702b0fe
2017-11-10Fixes for scanner info for Makefile projects.Doug Schaefer7-24/+162
Using ESP-IDF (the ESP32 FreeRTOS SDK) on MSYS2 as a test bed. Making sure the indexer picks up as much as it can. Removed -j since that messes up build output parsing. Add UI so you can put it back if you want. Change-Id: I767c739dce1412c75fb56d0bb1efceb913883a5f
2017-11-09Add settings to Makefile build configs to build at project root.Doug Schaefer9-18/+280
Often Makefile projects are intended to be built from the project root directory, such as ESP32 IDF projects. This adds a setting to control that. Change-Id: I151ebf60a7609461d24e192a9d6418fccb737055
2017-11-09Bug 527090: fix bad whitespace on windowsJonah Graham1-2/+2
Change-Id: Iba9d1ff94cc1ffa2bc53944256b4562a50f10c5a
2017-11-09Update Oomph's setup's API baseline to 9.3Jonah Graham1-2/+2
Change-Id: Ie711add7a26120d335384e7430d5e38e973b19bf
2017-11-09Bug 522367: prevent hang of -target-attach on Ubuntu 16.04 / GDB 7.11Jonah Graham7-12/+114
-target-attach on Ubuntu 16.04 / GDB 7.11 does not flush its error response, leaving CDT hanging in final launch sequence. Sending a newline to GDB after the target-attach causes GDB to flush the buffer so CDT sees the error. Change-Id: I8816ac6c88eeaffc6d243ebdae9eb347cfdc5cf0
2017-11-09Bug 527019 - Build not running in Container for Managed Make projectJeff Johnston1-9/+4
- the CommandLauncherManager.CommandLauncherWrapper class is designed to figure out what launcher to use after being created and a project is set, but it is not built for reuse - change the CommandLauncherWrapper class to reset the launcher back to null when the project gets set so that any reuse will be sure to get the correct internal launcher after resetting the project Change-Id: I2c0758ca53f7164d4bbd4a6f738acd7c7c042370
2017-11-09Bug 378302 - Only bring build console to top on problem output.Christian Walther4-10/+32
When the "Bring console to top when building (if present)" was enabled (which it is by default as of bug 447703), the console would come to the top on every line of output, i.e. constantly during a busy build. That made it impossible to reach other views in the same part, in particular the Progress view in order to stop the build. Instead, only bring the console to the top at the start of the build and when output arrives that is associated with a problem marker (error, warning, info). Change-Id: Iabda4858b443c330e9209c27ea3635b0485c7d98 Signed-off-by: Christian Walther <>
2017-11-09Bug 242705: Fix misaligned breakpoint iconJesper Eskilson6-3/+3
This commit fixes the "misalignment" of the breakpoint icon by replacing it with the same icon as JDT uses. Change-Id: I5a205a095dd37f61774adbf0fc61378ad29fe2bf Signed-off-by: Jesper Eskilson <>
2017-11-08Bug 512550 - Hide C and C++ Project Wizards and fix canFinish().Doug Schaefer3-23/+10
Hides the C Project and C++ Project wizards in the wizard shortcuts for the CPerspective. Also removes them from the shortcut list in the project navigator. Adds the C/C++ wizard that was missing from the project navigator. Also makes sure we pass along the call to canFinish from the new wizards to the old ones. Change-Id: I0a5505542fcf9d0eb34fb5fef790fd1e777524b5

Back to the top