summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBaltasar Belyavsky2013-05-14 13:21:55 (EDT)
committer Andrew Gvozdev2013-05-14 13:57:05 (EDT)
commite9dfe3c1e994fd132445468023d8c5836df7787a (patch)
tree938519166c6570ecd2f0a3378237087f14688c0b
parent12d8ae41e2ea4631e8ab6d5467019536d0a35db8 (diff)
downloadorg.eclipse.cdt-e9dfe3c1e994fd132445468023d8c5836df7787a.zip
org.eclipse.cdt-e9dfe3c1e994fd132445468023d8c5836df7787a.tar.gz
org.eclipse.cdt-e9dfe3c1e994fd132445468023d8c5836df7787a.tar.bz2
Bug 405638 - [performance] CExternalSettingsManager causes all workspacerefs/changes/35/11935/4
project-descriptions to load prematurely Change-Id: I814835ce63b358dcab4349cd88f205b9dbe81c85 Reviewed-on: https://git.eclipse.org/r/11935 Reviewed-by: Andrew Gvozdev <angvoz.dev@gmail.com> IP-Clean: Andrew Gvozdev <angvoz.dev@gmail.com> Tested-by: Andrew Gvozdev <angvoz.dev@gmail.com>
-rw-r--r--core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/CExternalSettingsManager.java4
1 files changed, 3 insertions, 1 deletions
diff --git a/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/CExternalSettingsManager.java b/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/CExternalSettingsManager.java
index 6f8c996..b586062 100644
--- a/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/CExternalSettingsManager.java
+++ b/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/CExternalSettingsManager.java
@@ -8,6 +8,7 @@
* Contributors:
* Intel Corporation - Initial API and implementation
* James Blackburn (Broadcom Corp.)
+ * Baltasar Belyavsky (Texas Instruments) - [405638] CExternalSettingsManager causes all workspace project-descriptions to load prematurely
*******************************************************************************/
package org.eclipse.cdt.internal.core.settings.model;
@@ -481,7 +482,8 @@ public class CExternalSettingsManager implements ICExternalSettingsListener, ICP
}
private ProjDesCfgList createCfgList(IProject project, Set<String> cfgIdSet){
- ICProjectDescription des = CProjectDescriptionManager.getInstance().getProjectDescription(project, false);
+ // ignore projects which haven't loaded yet - forcing them to load here is expensive and unnecessary [Bug 405638]
+ ICProjectDescription des = CProjectDescriptionManager.getInstance().getProjectDescription(project, false, false);
if(des == null)
return null;