Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSerge Beauchamp2013-11-05 13:43:06 +0000
committerMarc-Andre Laperle2013-11-07 04:05:37 +0000
commit3d9e51d8ae905a18426f216593eb920bca24b309 (patch)
treed2b9ad07f65beb5f4f77cabba01a430814938611
parent3e528ebafe873722a83c3bd379afcd2cab2e997f (diff)
downloadorg.eclipse.cdt-3d9e51d8ae905a18426f216593eb920bca24b309.tar.gz
org.eclipse.cdt-3d9e51d8ae905a18426f216593eb920bca24b309.tar.xz
org.eclipse.cdt-3d9e51d8ae905a18426f216593eb920bca24b309.zip
Bug 421070 - DwarfReader should scale better for large binaries
Change-Id: I9e085f7fc8e48b265d0e3aa36501e9ae3dadad91 Signed-off-by: Serge Beauchamp <sergebeauchamp@mac.com> Reviewed-on: https://git.eclipse.org/r/18081 Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com> IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com> Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
-rw-r--r--core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/debug/dwarf/DwarfReader.java6
1 files changed, 4 insertions, 2 deletions
diff --git a/core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/debug/dwarf/DwarfReader.java b/core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/debug/dwarf/DwarfReader.java
index 6a3beae3ce0..e784ec56d18 100644
--- a/core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/debug/dwarf/DwarfReader.java
+++ b/core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/debug/dwarf/DwarfReader.java
@@ -1,5 +1,5 @@
/*******************************************************************************
- * Copyright (c) 2007, 2010 Nokia and others.
+ * Copyright (c) 2007, 2013 Nokia and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
@@ -8,6 +8,7 @@
* Contributors:
* Nokia - initial API and implementation
* Ling Wang (Nokia) bug 201000
+ * Serge Beauchamp (Freescale Semiconductor) - Bug 421070
*******************************************************************************/
package org.eclipse.cdt.utils.debug.dwarf;
@@ -16,6 +17,7 @@ import java.io.IOException;
import java.nio.ByteBuffer;
import java.util.ArrayList;
import java.util.Collection;
+import java.util.HashSet;
import java.util.List;
import org.eclipse.cdt.core.CCorePlugin;
@@ -44,7 +46,7 @@ public class DwarfReader extends Dwarf implements ISymbolReader {
DWARF_DEBUG_STR // this is optional. Some compilers don't generate it.
};
- private final Collection<String> m_fileCollection = new ArrayList<String>();
+ private final Collection<String> m_fileCollection = new HashSet<String>();
private String[] m_fileNames = null;
private boolean m_parsed = false;
private final ArrayList<Integer> m_parsedLineTableOffsets = new ArrayList<Integer>();

Back to the top