Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlain Magloire2004-12-10 20:35:50 +0000
committerAlain Magloire2004-12-10 20:35:50 +0000
commit1760038cb3ce5bdbe40bad699901f2906e482b10 (patch)
treecf3ec9d93bfa99debbd8f77afda1729fbedb3033
parent813cd0a2c792e8e79bf9f594dfad84dbdf9b2b15 (diff)
downloadorg.eclipse.cdt-1760038cb3ce5bdbe40bad699901f2906e482b10.tar.gz
org.eclipse.cdt-1760038cb3ce5bdbe40bad699901f2906e482b10.tar.xz
org.eclipse.cdt-1760038cb3ce5bdbe40bad699901f2906e482b10.zip
2004-12-09 Alain Magloire
Fix for 80724: not showing initialized global variables. * utils/org/eclipse/cdt/utils/coff/parser/CygwinPEBinaryObject.java
-rw-r--r--core/org.eclipse.cdt.core/ChangeLog4
-rw-r--r--core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/coff/parser/CygwinPEBinaryObject.java7
2 files changed, 10 insertions, 1 deletions
diff --git a/core/org.eclipse.cdt.core/ChangeLog b/core/org.eclipse.cdt.core/ChangeLog
index 2a3f5905710..19653ecb202 100644
--- a/core/org.eclipse.cdt.core/ChangeLog
+++ b/core/org.eclipse.cdt.core/ChangeLog
@@ -1,3 +1,7 @@
+2004-12-09 Alain Magloire
+ Fix for 80724: not showing initialized global variables.
+ * utils/org/eclipse/cdt/utils/coff/parser/CygwinPEBinaryObject.java
+
2004-12-10 David Inglis
Fixed bug #80713
diff --git a/core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/coff/parser/CygwinPEBinaryObject.java b/core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/coff/parser/CygwinPEBinaryObject.java
index 55ebb4e7504..891f6402ac4 100644
--- a/core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/coff/parser/CygwinPEBinaryObject.java
+++ b/core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/coff/parser/CygwinPEBinaryObject.java
@@ -15,6 +15,7 @@ import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
+import org.eclipse.cdt.core.CConventions;
import org.eclipse.cdt.core.IAddress;
import org.eclipse.cdt.core.IBinaryParser;
import org.eclipse.cdt.core.IBinaryParser.ISymbol;
@@ -191,6 +192,10 @@ public class CygwinPEBinaryObject extends PEBinaryObject {
for (int i = 0; i < pairs.length; ++i) {
addSymbol(pairs[i], list, ISymbol.VARIABLE);
}
+ pairs = nm.getDataSymbols();
+ for (int i = 0; i < pairs.length; ++i) {
+ addSymbol(pairs[i], list, ISymbol.VARIABLE);
+ }
}
// pairs = nm.getTextSymbols();
// for (int i = 0; i < pairs.length; ++i) {
@@ -216,7 +221,7 @@ public class CygwinPEBinaryObject extends PEBinaryObject {
private void addSymbol(NM.AddressNamePair p, List list, int type) {
String name = p.name;
- if (name != null && name.length() > 0 && Character.isJavaIdentifierStart(name.charAt(0))) {
+ if (name != null && name.length() > 0 && CConventions.isValidIdentifier(name)) {
IAddress addr = new Addr32(p.address);
int size = 4;
if (symbolLoadingCPPFilt != null) {

Back to the top