Skip to main content
summaryrefslogtreecommitdiffstats
path: root/qt
diff options
context:
space:
mode:
authorAndrew Eidsness2014-01-28 07:38:30 -0500
committerDoug Schaefer2014-01-29 16:12:49 -0500
commit71fa7cf81983c8fd2179157876975f203a2bb5e8 (patch)
treeb23070725958f2683bef3221baa3565d394a8ef1 /qt
parentd613b149a06e728ffd000fc9b5f398a542a4e80f (diff)
downloadorg.eclipse.cdt-71fa7cf81983c8fd2179157876975f203a2bb5e8.tar.gz
org.eclipse.cdt-71fa7cf81983c8fd2179157876975f203a2bb5e8.tar.xz
org.eclipse.cdt-71fa7cf81983c8fd2179157876975f203a2bb5e8.zip
Bug 426784: Qt Codan checker uses wrong type
view.connect( view.engine(), SIGNAL( quit() ), ... The return type of view.engine() should be checked for the quit() signal. The implementation was actually checking the type of view. I've fixed a copy/paste error in a utility function. Change-Id: Id483015214f04951fb30e3271d43499f31614446 Signed-off-by: Andrew Eidsness <eclipse@jfront.com> Reviewed-on: https://git.eclipse.org/r/21189 Reviewed-by: Doug Schaefer <dschaefer@qnx.com> IP-Clean: Doug Schaefer <dschaefer@qnx.com> Tested-by: Doug Schaefer <dschaefer@qnx.com>
Diffstat (limited to 'qt')
-rw-r--r--qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/ASTUtil.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/ASTUtil.java b/qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/ASTUtil.java
index 4deccf48a9..e18152b0b9 100644
--- a/qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/ASTUtil.java
+++ b/qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/ASTUtil.java
@@ -130,7 +130,7 @@ public class ASTUtil {
if (node instanceof IASTIdExpression)
return getBaseType((IASTIdExpression) node);
if (node instanceof IASTFunctionCallExpression)
- return getReceiverType((IASTFunctionCallExpression) node);
+ return getBaseType((IASTFunctionCallExpression) node);
if (node instanceof IASTExpression)
return getBaseType(((IASTExpression) node).getExpressionType());

Back to the top