diff options
| author | Alex Blewitt | 2016-04-15 22:41:51 +0000 |
|---|---|---|
| committer | Gerrit Code Review @ Eclipse.org | 2016-04-16 16:17:48 +0000 |
| commit | fc07efa909ea2702da76fe9842d258b96b4bc925 (patch) | |
| tree | 7517debc7b91ae0d31e948c22b3a6a3c22638467 /dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/internal/ui | |
| parent | 0b7b2a87d365db7620ce42f571733bb6453225ca (diff) | |
| download | org.eclipse.cdt-fc07efa909ea2702da76fe9842d258b96b4bc925.tar.gz org.eclipse.cdt-fc07efa909ea2702da76fe9842d258b96b4bc925.tar.xz org.eclipse.cdt-fc07efa909ea2702da76fe9842d258b96b4bc925.zip | |
Bug 491825 - Remove primitive wrapper creation
Using `new Integer` and other wrapper types such as `new Character` results in
potential extra heap utilisation as the values are not cached. The built-in
`Integer.valueOf` will perform caching on numbers in the range -128..127 (at
least) using a flyweight pattern. In addition, parsing `int` values can be done
with `Integer.parseInt` which avoids object construction.
Adjust tests such as `"true".equals(expr)` to `Boolean.parseBoolean(expr)`.
Change-Id: I0408a5c69afc4ca6ede71acaf6cc4abd67538006
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
Diffstat (limited to 'dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/internal/ui')
| -rw-r--r-- | dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/internal/ui/DsfUIPlugin.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/internal/ui/DsfUIPlugin.java b/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/internal/ui/DsfUIPlugin.java index a6e95a7b362..f13b6765091 100644 --- a/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/internal/ui/DsfUIPlugin.java +++ b/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/internal/ui/DsfUIPlugin.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2006, 2014 Wind River Systems and others. + * Copyright (c) 2006, 2016 Wind River Systems and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -61,7 +61,7 @@ public class DsfUIPlugin extends AbstractUIPlugin { public void start(BundleContext context) throws Exception { fgBundleContext = context; super.start(context); - DEBUG = "true".equals(Platform.getDebugOption("org.eclipse.cdt.dsf.ui/debug")); //$NON-NLS-1$//$NON-NLS-2$ + DEBUG = Boolean.parseBoolean(Platform.getDebugOption("org.eclipse.cdt.dsf.ui/debug")); //$NON-NLS-1$//$NON-NLS-2$ fSourceDocumentProvider = new SourceDocumentProvider(); |