Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarc Khouzam2011-05-09 00:14:16 +0000
committerMarc Khouzam2011-05-09 00:14:16 +0000
commit5ae69e168a0fab0dd2e13a99f28d04e9b3cc9d7f (patch)
treeaa6485abdd433e4b6a257a784f5aa8495169ac4c /dsf-gdb
parent46ac14620b6cc4ae01d89ca0428c4bea47911b92 (diff)
downloadorg.eclipse.cdt-5ae69e168a0fab0dd2e13a99f28d04e9b3cc9d7f.tar.gz
org.eclipse.cdt-5ae69e168a0fab0dd2e13a99f28d04e9b3cc9d7f.tar.xz
org.eclipse.cdt-5ae69e168a0fab0dd2e13a99f28d04e9b3cc9d7f.zip
Bug 344892: Deadlock when trying to attach to more than one process on a remote target. Small cleanup
Diffstat (limited to 'dsf-gdb')
-rw-r--r--dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/actions/GdbConnectCommand.java8
1 files changed, 4 insertions, 4 deletions
diff --git a/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/actions/GdbConnectCommand.java b/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/actions/GdbConnectCommand.java
index a4b1be91060..c6282f4dbcb 100644
--- a/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/actions/GdbConnectCommand.java
+++ b/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/actions/GdbConnectCommand.java
@@ -159,22 +159,22 @@ public class GdbConnectCommand implements IConnect {
@Override
public IStatus runInUIThread(IProgressMonitor monitor) {
- final String[] binaryPath = new String[1];
- binaryPath[0] = null;
+ String binaryPath = null;
Shell shell = Display.getCurrent().getActiveShell();
if (shell != null) {
FileDialog fd = new FileDialog(shell, SWT.NONE);
- binaryPath[0] = fd.open();
+ binaryPath = fd.open();
}
+ final String finalBinaryPath = binaryPath;
fExecutor.execute(new DsfRunnable() {
public void run() {
IGDBProcesses procService = fTracker.getService(IGDBProcesses.class);
ICommandControlService commandControl = fTracker.getService(ICommandControlService.class);
IProcessDMContext procDmc = procService.createProcessContext(commandControl.getContext(), fPid);
- procService.attachDebuggerToProcess(procDmc, binaryPath[0], new DataRequestMonitor<IDMContext>(fExecutor, fRm));
+ procService.attachDebuggerToProcess(procDmc, finalBinaryPath, new DataRequestMonitor<IDMContext>(fExecutor, fRm));
}
});

Back to the top