Bug 353351 - DisassemblyBackendDsf.retrieveFrameAddressInSessionThread()

shows an error message to the user if stack.getFrameData fails.

1 files changed, 18 insertions, 1 deletions

diff --git a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/AbstractDisassemblyBackend.java b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/AbstractDisassemblyBackend.java
index 22aa785ba20..8efc39bfd21 100644
--- a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/AbstractDisassemblyBackend.java
+++ b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/AbstractDisassemblyBackend.java
@@ -8,12 +8,16 @@
  * Contributors:
  *     Wind River Systems - initial API and implementation
  *     Freescale Semiconductor - refactoring
- *     Patrick Chuong (Texas Instruments) - Bug fix (329682)
+ *     Patrick Chuong (Texas Instruments) - Bug 329682
+ *     Patrick Chuong (Texas Instruments) - Bug 353351
  *******************************************************************************/
 package org.eclipse.cdt.debug.internal.ui.disassembly.dsf;
 
 import java.math.BigInteger;
 
+import org.eclipse.core.runtime.IStatus;
+import org.eclipse.jface.dialogs.ErrorDialog;
+
 public abstract class AbstractDisassemblyBackend implements IDisassemblyBackend {
 
 	protected IDisassemblyPartCallback fCallback;
@@ -46,4 +50,17 @@ public abstract class AbstractDisassemblyBackend implements IDisassemblyBackend
     	return null;
 	}
 
+	/**
+	 * Default error handler, sub-class can override this method to provide it's own error handling.
+	 *  
+	 * @param status
+	 */
+	protected void handleError(final IStatus status) {
+		fCallback.asyncExec(new Runnable() {
+			@Override
+			public void run() {
+				ErrorDialog.openError(fCallback.getSite().getShell(), "Error", null, status); //$NON-NLS-1$
+			}
+		});				
+	}
 }