Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnton Leherbauer2010-11-16 04:35:38 -0500
committerAnton Leherbauer2010-11-16 04:35:38 -0500
commit009a2d052308f4e0e2458a1da4e8767c0a899f84 (patch)
treef50dc57b3f64f1ab7a48c5385013e556963c6add /debug/org.eclipse.cdt.debug.ui
parentb5c0570748e6170890c6aa5c04c7f45ab92058e0 (diff)
downloadorg.eclipse.cdt-009a2d052308f4e0e2458a1da4e8767c0a899f84.tar.gz
org.eclipse.cdt-009a2d052308f4e0e2458a1da4e8767c0a899f84.tar.xz
org.eclipse.cdt-009a2d052308f4e0e2458a1da4e8767c0a899f84.zip
Bug 329682 - Rename method "evaluateSymbolAddress" to "evaluateAddressExpression"
Diffstat (limited to 'debug/org.eclipse.cdt.debug.ui')
-rw-r--r--debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/AbstractDisassemblyBackend.java13
-rw-r--r--debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/DisassemblyBackendCdi.java4
-rw-r--r--debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/IDisassemblyBackend.java1
3 files changed, 10 insertions, 8 deletions
diff --git a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/AbstractDisassemblyBackend.java b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/AbstractDisassemblyBackend.java
index ac1f9f15fc..a1c266bf5c 100644
--- a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/AbstractDisassemblyBackend.java
+++ b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/AbstractDisassemblyBackend.java
@@ -8,6 +8,7 @@
* Contributors:
* Wind River Systems - initial API and implementation
* Freescale Semiconductor - refactoring
+ * Patrick Chuong (Texas Instruments) - Bug fix (329682)
*******************************************************************************/
package org.eclipse.cdt.debug.internal.ui.disassembly.dsf;
@@ -26,12 +27,14 @@ public abstract class AbstractDisassemblyBackend implements IDisassemblyBackend
}
/**
- * Evaluate the symbol address.
+ * Evaluate the expression to an address. This might be the address of a symbol or
+ * the value of the numeric evaluation depending on the type of the expression.
*
- * @param symbol the symbol
- * @param suppressError true to suppress error dialogs
- * @return the address, <code>null</code> if failed to evaluate symbol
+ * @param expression the expression
+ * @param suppressError <code>true</code> to suppress error dialogs
+ * @return the address or <code>null</code> if the expression could not be evaluated
+ * @since 7.0
*/
- public abstract BigInteger evaluateSymbolAddress(String symbol, boolean suppressError);
+ public abstract BigInteger evaluateAddressExpression(String expression, boolean suppressError);
}
diff --git a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/DisassemblyBackendCdi.java b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/DisassemblyBackendCdi.java
index 116eb87669..b453ddb3e1 100644
--- a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/DisassemblyBackendCdi.java
+++ b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/DisassemblyBackendCdi.java
@@ -348,7 +348,7 @@ public class DisassemblyBackendCdi extends AbstractDisassemblyBackend implements
* @see org.eclipse.cdt.dsf.debug.internal.ui.disassembly.IDisassemblyBackend#gotoSymbol(java.lang.String)
*/
public void gotoSymbol(String symbol) {
- final BigInteger address = evaluateSymbolAddress(symbol, false);
+ final BigInteger address = evaluateAddressExpression(symbol, false);
if (address != null) {
fCallback.asyncExec(new Runnable() {
public void run() {
@@ -361,7 +361,7 @@ public class DisassemblyBackendCdi extends AbstractDisassemblyBackend implements
* (non-Javadoc)
* @see org.eclipse.cdt.debug.internal.ui.disassembly.dsf.IDisassemblyBackend#evaluateSymbolAddress(java.lang.String, boolean)
*/
- public BigInteger evaluateSymbolAddress(String symbol, final boolean suppressError) {
+ public BigInteger evaluateAddressExpression(String symbol, final boolean suppressError) {
if (fTargetFrameContext != null) {
try {
// This logic was lifted from CMemoryBlockRetrievalExtension.getExtendedMemoryBlock(String, Object)
diff --git a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/IDisassemblyBackend.java b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/IDisassemblyBackend.java
index dfba77dcf0..ec8b802467 100644
--- a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/IDisassemblyBackend.java
+++ b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/IDisassemblyBackend.java
@@ -8,7 +8,6 @@
* Contributors:
* Wind River Systems - initial API and implementation
* Freescale Semiconductor - refactoring
- * Patrick Chuong (Texas Instruments) - Bug fix (329682)
*******************************************************************************/
package org.eclipse.cdt.debug.internal.ui.disassembly.dsf;

Back to the top