Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNathan Ridge2013-07-09 02:23:22 +0000
committerSergey Prigogin2013-07-09 17:05:16 +0000
commitc5b4670184ef9fb62f92cff55e2b6d4c6cf475dd (patch)
treec81446fb38b460c46390d11a909c31e2e1b5fa28 /codan/org.eclipse.cdt.codan.checkers
parentdb70bb0f2964bce706b49852bc6e3787d87c4d0a (diff)
downloadorg.eclipse.cdt-c5b4670184ef9fb62f92cff55e2b6d4c6cf475dd.tar.gz
org.eclipse.cdt-c5b4670184ef9fb62f92cff55e2b6d4c6cf475dd.tar.xz
org.eclipse.cdt-c5b4670184ef9fb62f92cff55e2b6d4c6cf475dd.zip
Bug 400673 - [c++11] Unnecessary warning in class constructor (not
initialized member) when using "in class member initialization" Change-Id: I4e6af3b0927d44f0bb5417d7788fc9a026f8fb7c Signed-off-by: Nathan Ridge <zeratul976@hotmail.com> Reviewed-on: https://git.eclipse.org/r/14397 Reviewed-by: Sergey Prigogin <eclipse.sprigogin@gmail.com> IP-Clean: Sergey Prigogin <eclipse.sprigogin@gmail.com> Tested-by: Sergey Prigogin <eclipse.sprigogin@gmail.com>
Diffstat (limited to 'codan/org.eclipse.cdt.codan.checkers')
-rw-r--r--codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/ClassMembersInitializationChecker.java6
1 files changed, 5 insertions, 1 deletions
diff --git a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/ClassMembersInitializationChecker.java b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/ClassMembersInitializationChecker.java
index 8c7b66fa67c..3556fbfa9aa 100644
--- a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/ClassMembersInitializationChecker.java
+++ b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/ClassMembersInitializationChecker.java
@@ -92,7 +92,11 @@ public class ClassMembersInitializationChecker extends AbstractIndexAstChecker {
// Add all class fields
for (IField field : ClassTypeHelper.getDeclaredFields(constructor.getClassOwner(), declaration)) {
if (isSimpleType(field.getType()) && !field.isStatic()) {
- fieldsInConstructor.add(field);
+ // In C++11, a field may have an initial value specified at its declaration.
+ // Such a field does not need to be initialized in the constructor as well.
+ if (field.getInitialValue() == null) {
+ fieldsInConstructor.add(field);
+ }
}
}
}

Back to the top