Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Kurtakov2015-10-26 15:43:23 -0400
committerGerrit Code Review @ Eclipse.org2015-10-27 18:45:17 -0400
commit59263ecc0249ce85378ec2155b3dc0b77c757430 (patch)
tree55d53e6d0d7905e5624acc1c1241ccdc7c7ea6a0 /build/org.eclipse.cdt.autotools.core/src
parenta9730dc1941bc31c7bb3369497956cfe06b4a4b9 (diff)
downloadorg.eclipse.cdt-59263ecc0249ce85378ec2155b3dc0b77c757430.tar.gz
org.eclipse.cdt-59263ecc0249ce85378ec2155b3dc0b77c757430.tar.xz
org.eclipse.cdt-59263ecc0249ce85378ec2155b3dc0b77c757430.zip
autotools: Remove redundant and unused modifiers.
Reducing sonar warnings is good strategy to keep new warnings easily noticable. Interface methods/fields have strict modifiers so no need to specify it. Change-Id: I8c453b5dbdc3c7fcc37e4e0a4fdf1c600e23fb1a Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Diffstat (limited to 'build/org.eclipse.cdt.autotools.core/src')
-rw-r--r--build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/IAutotoolsMarker.java10
-rw-r--r--build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/IConfigurationCloneListener.java2
-rw-r--r--build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/configure/IAConfiguration.java38
-rw-r--r--build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/configure/IConfigureOption.java58
4 files changed, 67 insertions, 41 deletions
diff --git a/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/IAutotoolsMarker.java b/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/IAutotoolsMarker.java
index a85a55e344..d52d4f9761 100644
--- a/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/IAutotoolsMarker.java
+++ b/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/IAutotoolsMarker.java
@@ -13,9 +13,9 @@ package org.eclipse.cdt.internal.autotools.core;
import org.eclipse.cdt.autotools.core.AutotoolsPlugin;
public interface IAutotoolsMarker {
- public static String AUTOTOOLS_PROBLEM_MARKER = AutotoolsPlugin.PLUGIN_ID + ".problem"; //$NON-NLS-1$
- public static final String MARKER_VARIABLE = "problem.variable"; //$NON-NLS-1$
- public static final String MARKER_EXTERNAL_LOCATION = "problem.externalLocation"; //$NON-NLS-1$
- public static final String MARKER_LIBRARY_INFO="problem.libraryInfo"; //$NON-NLS-1$
- public static final String MARKER_PROBLEM_TYPE="problem.type"; //$NON-NLS-1$
+ String AUTOTOOLS_PROBLEM_MARKER = AutotoolsPlugin.PLUGIN_ID + ".problem"; //$NON-NLS-1$
+ String MARKER_VARIABLE = "problem.variable"; //$NON-NLS-1$
+ String MARKER_EXTERNAL_LOCATION = "problem.externalLocation"; //$NON-NLS-1$
+ String MARKER_LIBRARY_INFO = "problem.libraryInfo"; //$NON-NLS-1$
+ String MARKER_PROBLEM_TYPE = "problem.type"; //$NON-NLS-1$
}
diff --git a/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/IConfigurationCloneListener.java b/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/IConfigurationCloneListener.java
index 60d7b9611c..e98b8b18e4 100644
--- a/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/IConfigurationCloneListener.java
+++ b/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/IConfigurationCloneListener.java
@@ -8,5 +8,5 @@ public interface IConfigurationCloneListener {
* @param cloneName - name of the cloned configuration
* @param c - the clone
*/
- public void cloneCfg(String cloneName, IConfiguration c);
+ void cloneCfg(String cloneName, IConfiguration c);
}
diff --git a/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/configure/IAConfiguration.java b/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/configure/IAConfiguration.java
index f71e1ee0ab..01b35e332b 100644
--- a/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/configure/IAConfiguration.java
+++ b/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/configure/IAConfiguration.java
@@ -14,17 +14,29 @@ import java.util.ArrayList;
import java.util.Map;
public interface IAConfiguration {
- public IConfigureOption getOption(String name);
- public String getId();
- public boolean isDirty();
- public void setDirty(boolean value);
- public Map<String, IConfigureOption> getOptions();
- public String getToolParameters(String name);
- public ArrayList<String> getToolArgs(String name);
- public void setOption(String name, String value);
- public void setConfigToolDirectory(String configToolDirectory);
- public String getConfigToolDirectory();
- public IAConfiguration copy();
- public IAConfiguration copy(String id);
- public void setDefaultOptions();
+ IConfigureOption getOption(String name);
+
+ String getId();
+
+ boolean isDirty();
+
+ void setDirty(boolean value);
+
+ Map<String, IConfigureOption> getOptions();
+
+ String getToolParameters(String name);
+
+ ArrayList<String> getToolArgs(String name);
+
+ void setOption(String name, String value);
+
+ void setConfigToolDirectory(String configToolDirectory);
+
+ String getConfigToolDirectory();
+
+ IAConfiguration copy();
+
+ IAConfiguration copy(String id);
+
+ void setDefaultOptions();
}
diff --git a/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/configure/IConfigureOption.java b/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/configure/IConfigureOption.java
index 07b709094d..10adc1092e 100644
--- a/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/configure/IConfigureOption.java
+++ b/build/org.eclipse.cdt.autotools.core/src/org/eclipse/cdt/internal/autotools/core/configure/IConfigureOption.java
@@ -16,26 +16,40 @@ import org.eclipse.cdt.autotools.core.IAutotoolsOption;
public interface IConfigureOption {
- public final static int CATEGORY = IAutotoolsOption.CATEGORY;
- public final static int BIN = IAutotoolsOption.BIN;
- public final static int STRING = IAutotoolsOption.STRING;
- public final static int INTERNAL = IAutotoolsOption.INTERNAL;
- public final static int MULTIARG = IAutotoolsOption.MULTIARG;
- public final static int TOOL = IAutotoolsOption.TOOL;
- public final static int FLAG = IAutotoolsOption.FLAG;
- public final static int FLAGVALUE = IAutotoolsOption.FLAGVALUE;
- public String getName();
- public String getParameter();
- public ArrayList<String> getParameters();
- public boolean isParmSet();
- public String getDescription();
- public String getToolTip();
- public void setValue(String value);
- public IConfigureOption copy(AutotoolsConfiguration cfg);
- public String getValue();
- public boolean isCategory();
- public boolean isMultiArg();
- public boolean isFlag();
- public boolean isFlagValue();
- public int getType();
+ int CATEGORY = IAutotoolsOption.CATEGORY;
+ int BIN = IAutotoolsOption.BIN;
+ int STRING = IAutotoolsOption.STRING;
+ int INTERNAL = IAutotoolsOption.INTERNAL;
+ int MULTIARG = IAutotoolsOption.MULTIARG;
+ int TOOL = IAutotoolsOption.TOOL;
+ int FLAG = IAutotoolsOption.FLAG;
+ int FLAGVALUE = IAutotoolsOption.FLAGVALUE;
+
+ String getName();
+
+ String getParameter();
+
+ ArrayList<String> getParameters();
+
+ boolean isParmSet();
+
+ String getDescription();
+
+ String getToolTip();
+
+ void setValue(String value);
+
+ IConfigureOption copy(AutotoolsConfiguration cfg);
+
+ String getValue();
+
+ boolean isCategory();
+
+ boolean isMultiArg();
+
+ boolean isFlag();
+
+ boolean isFlagValue();
+
+ int getType();
}

Back to the top