| author | pshi | 2012-08-06 23:11:03 (EDT) |
|---|---|---|
| committer | mwu | 2012-08-06 23:11:03 (EDT) |
| commit | 66f53876adc9fdebd7903beaf697711e08406dda (patch) (side-by-side diff) | |
| tree | 1cd2315501aa6cf88c612c4c38150c15103f2915 | |
| parent | 754b776bfa30f2535099bb7f81374aa533f52e7f (diff) | |
| download | org.eclipse.birt-66f53876adc9fdebd7903beaf697711e08406dda.zip org.eclipse.birt-66f53876adc9fdebd7903beaf697711e08406dda.tar.gz org.eclipse.birt-66f53876adc9fdebd7903beaf697711e08406dda.tar.bz2 | |
Fix 51998 [BZ]BIRT report w/ parameter fails with exception when ?
placed in SQL where clause
Resolve of issue:
It is not necessary to call ParameterMetaData#getParameterType here and
it will cause other bugs, roll back the fix in 49046
| -rw-r--r-- | data/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/executor/DataSourceQuery.java | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/data/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/executor/DataSourceQuery.java b/data/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/executor/DataSourceQuery.java index c96f1cd..762b269 100644 --- a/data/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/executor/DataSourceQuery.java +++ b/data/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/executor/DataSourceQuery.java @@ -1133,12 +1133,9 @@ public class DataSourceQuery extends BaseQuery implements IDataSourceQuery, IPre // set input parameter bindings Iterator inputParamValueslist = getInputParamValues().iterator( ); - int inputParam = 1; - while ( inputParamValueslist.hasNext( ) - && ( odaStatement.getParameterMetaData( ).size( ) >= inputParam ) ) + while ( inputParamValueslist.hasNext( ) ) { ParameterBinding paramBind = (ParameterBinding) inputParamValueslist.next( ); - inputParam++; if ( paramBind.getPosition( ) <= 0 || odaStatement.supportsNamedParameter( )) { try |